Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 10831043: gesture recognizer: Fix computing the bounding box of the rectangles. (Closed)

Created:
8 years, 5 months ago by sadrul
Modified:
8 years, 4 months ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews
Visibility:
Public.

Description

gesture recognizer: Fix computing the bounding box of the rectangles. Accumulating all the positions of the touch-events of a single touch-point during its entire lifetime is not very useful. So instead, stop accumulating the positions when the point leaves the manhattan square. BUG=139175 TEST=none TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148750

Patch Set 1 : . #

Patch Set 2 : update-tests #

Patch Set 3 : new-test #

Patch Set 4 : stress #

Total comments: 2

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -3 lines) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 3 4 15 chunks +78 lines, -0 lines 0 comments Download
M ui/base/gestures/gesture_point.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
8 years, 5 months ago (2012-07-27 00:56:05 UTC) #1
rjkroege
LGTM with a micro-nit http://codereview.chromium.org/10831043/diff/7004/ui/aura/gestures/gesture_recognizer_unittest.cc File ui/aura/gestures/gesture_recognizer_unittest.cc (right): http://codereview.chromium.org/10831043/diff/7004/ui/aura/gestures/gesture_recognizer_unittest.cc#newcode719 ui/aura/gestures/gesture_recognizer_unittest.cc:719: // When scrolling with a ...
8 years, 4 months ago (2012-07-27 14:16:48 UTC) #2
sadrul
http://codereview.chromium.org/10831043/diff/7004/ui/aura/gestures/gesture_recognizer_unittest.cc File ui/aura/gestures/gesture_recognizer_unittest.cc (right): http://codereview.chromium.org/10831043/diff/7004/ui/aura/gestures/gesture_recognizer_unittest.cc#newcode719 ui/aura/gestures/gesture_recognizer_unittest.cc:719: // When scrolling with a sinle finger, the bounding ...
8 years, 4 months ago (2012-07-27 14:46:46 UTC) #3
sadrul
8 years, 4 months ago (2012-07-27 14:47:44 UTC) #4
+sky@ for aura OWNERs (TBR'ing the test change)

Powered by Google App Engine
This is Rietveld 408576698