Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 10831042: Revert 148676 - Revert revert of 146149 - Don't pass the connector check policy flag along. (Closed)

Created:
8 years, 4 months ago by Scott Byer
Modified:
8 years, 4 months ago
Reviewers:
Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 148676 - Revert revert of 146149 - Don't pass the connector check policy flag along. If a browser is running, and the service process is running the connector, the connector will occasionally start up a chromium process to check the connector enablement policy. The flag to do so would get passed to a running browser, if present, and there is a path through the policy check code that could cause the browser to quit. This patch prevents the policy check flag from being passed on; the started process will be very short lived and does a silent launch. Original Review URL: https://chromiumcodereview.appspot.com/10666010 BUG=134252 TEST=None Review URL: https://chromiumcodereview.appspot.com/10692178 TBR=scottbyer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -98 lines) Patch
M chrome/browser/chrome_browser_main.cc View 3 chunks +4 lines, -11 lines 0 comments Download
D chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_result_codes.h View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Scott Byer
8 years, 4 months ago (2012-07-27 00:52:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698