Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 10831041: [Chromoting] Fix keystone install script to use .pkg instead of .mpkg. (Closed)

Created:
8 years, 5 months ago by garykac
Modified:
8 years, 5 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Fix keystone install script to use .pkg instead of .mpkg. Iceberg builds .mpkgs, but Packages builds flat .pkgs. We switch to using Packages because it can create "flag packages" that we can sign and signing is required for Mac OS X 10.8. When we switched from .mpkg to .pkg, the keystone installer script was not updated. So keystone installs are not happening. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/host/installer/mac/Scripts/keystone_install.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
garykac
8 years, 5 months ago (2012-07-26 23:37:38 UTC) #1
Jamie
8 years, 5 months ago (2012-07-26 23:38:05 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698