NaCl settings and completed install scripts.

NaCl settings and completed install scripts.

I'm sorry this looks monstrously large, I touched many files.  Only .bat .py and .cs files need reviewing. Also note that the NaCl.Build.CPPTasks project is unchanged from what blueshift handed us. Noel and I have decided to ignore the different style for now.


Added script to download custom GDB and place in nacl-sdk folder.  Fixed resource error with NaCl template project.

Fixed OutDir macro issue with OutputFile, changed it to TargetDir instead. Changed the test projects to be copied from the same project during test setup, and have them add the templates so they are fresh. Fixed settings in PPAPI and NaCl templates.

Fixed developer_deploy script and other scripts to allow execution from any directory.

Changed the NaCl platform settings to be good defaults. Added VSNaClSDKRoot.  Added developer_deploy script.

Added the NaCl template XML and corresponding project.

Completed the install scripts. Now asks user permission to do everything.

Changed the create_package script to include anything and everything under the InstallerResources directory instead of listing all files individually.


BUG=136414
TEST=

Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1405

[binji, 2012-07-26 23:32:17]

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File
visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py
(right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py:193:
# Optionally pass in MS Build installation directory.
now that you have args, you should really add optparse. That way a user who runs
with "--help" will get something useful.

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.bat (right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/install.bat:2: setlocal
reading up on this, is this necessary? seems like it will prevent modifications
to the local environment from the batch file, but you don't change the
environment here.
(changes to the environment from the python script won't propagate to the batch
script).

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:51:
add_in_directory = raw_input().strip()
use command line args instead of raw_input

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:88: shutil.copy(
Make sure to clean up copied files if an exception is thrown... don't want to
have a half-installed plugin.

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File visual_studio/NativeClientVSAddIn/InstallerResources/install_custom_gdb.py
(right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/install_custom_gdb.py:18: +
"/debugging-untrusted-code-with-a-special-gdb-build-on-windows"
+ is unnecessary

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/install_custom_gdb.py:35:
zip_file.extract('gdb-remote-x86-64/gdb.exe', nacl_sdk_root)
remove zip after extraction?

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File visual_studio/NativeClientVSAddIn/create_package.py (right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/create_package.py:35:
'NativeClientVSAddIn.dll'),
Maybe change to (path, zip_dir) to remove duplication

[noelallen1, 2012-07-27 00:17:41]

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/ImportAfter/NaCl.override.props
(right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/ImportAfter/NaCl.override.props:15:
<LocalDebuggerCommandArguments>--enable-nacl-debug
localhost:5103</LocalDebuggerCommandArguments>
do you need: --no-sandbox?

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Paths.default.props
(right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Paths.default.props:24:
<LibraryPath Condition="'$(LibraryPath)' == '' AND
'$(TargetArchitecture)'=='i686'">$(VSNaClSDKRoot)lib32;</LibraryPath>
Should this be x86_32?

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Properties/nacl_general.xml
(right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Properties/nacl_general.xml:19:
Description="Specifies the path to the Native Client SDK root directory"
Does this point to SDK root?  or a particular pepper directory?

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right):

https://chromiumcodereview.appspot.com/10831030/diff/1/visual_studio/NativeCl...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:38:
nacl_sdk_root = os.getenv('NACL_SDK_ROOT', None)
This is somewhat dubious...  Admin and normal user may have different
environment settings, so I'm not sure this is a legit check.

[tysand, 2012-07-28 01:13:11]

Implemented suggestions and fixed a few bugs.

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/ImportAfter/NaCl.override.props
(right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/ImportAfter/NaCl.override.props:15:
<LocalDebuggerCommandArguments>--enable-nacl-debug
localhost:5103</LocalDebuggerCommandArguments>
On 2012/07/27 00:17:41, noelallen1 wrote:
> do you need: --no-sandbox?

Done.

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Paths.default.props
(right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Paths.default.props:24:
<LibraryPath Condition="'$(LibraryPath)' == '' AND
'$(TargetArchitecture)'=='i686'">$(VSNaClSDKRoot)lib32;</LibraryPath>
Nope, this is refering to the tool name's architecture which is currently i686
and x86_64.
On 2012/07/27 00:17:41, noelallen1 wrote:
> Should this be x86_32?

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Properties/nacl_general.xml
(right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Properties/nacl_general.xml:19:
Description="Specifies the path to the Native Client SDK root directory"
VSNaClSDKRoot defaults to $(NACL_SDK_ROOT) which we decided should point to a
particular pepper version.  We could however have the user set $(NACL_SDK_ROOT)
to the actual root and then have VCNaClSDKRoot default to
$(NACL_SDK_ROOT)\pepper_20 or whatever version is supported by the add-in.
However, I think NACL_SDK_ROOT is used outside of the Visual Studio add-in, so
we would need to assess those changes too?
On 2012/07/27 00:17:41, noelallen1 wrote:
> Does this point to SDK root?  or a particular pepper directory?

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File
visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py
(right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py:193:
# Optionally pass in MS Build installation directory.
On 2012/07/26 23:32:17, binji wrote:
> now that you have args, you should really add optparse. That way a user who
runs
> with "--help" will get something useful.

Done.

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.bat (right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install.bat:2: setlocal
I think you are right, it was mostly a precaution. I will remove it.
On 2012/07/26 23:32:17, binji wrote:
> reading up on this, is this necessary? seems like it will prevent
modifications
> to the local environment from the batch file, but you don't change the
> environment here.
> (changes to the environment from the python script won't propagate to the
batch
> script).

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:38:
nacl_sdk_root = os.getenv('NACL_SDK_ROOT', None)
Good catch, but I've verified that running python as admin keeps the original
user environment variables so we're OK.
On 2012/07/27 00:17:41, noelallen1 wrote:
> This is somewhat dubious...  Admin and normal user may have different
> environment settings, so I'm not sure this is a legit check.

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:51:
add_in_directory = raw_input().strip()
On 2012/07/26 23:32:17, binji wrote:
> use command line args instead of raw_input

Done.

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:88: shutil.copy(
On 2012/07/26 23:32:17, binji wrote:
> Make sure to clean up copied files if an exception is thrown... don't want to
> have a half-installed plugin.

Done.

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/InstallerResources/install_custom_gdb.py
(right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install_custom_gdb.py:18: +
"/debugging-untrusted-code-with-a-special-gdb-build-on-windows"
On 2012/07/26 23:32:17, binji wrote:
> + is unnecessary

Done.

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/install_custom_gdb.py:35:
zip_file.extract('gdb-remote-x86-64/gdb.exe', nacl_sdk_root)
On 2012/07/26 23:32:17, binji wrote:
> remove zip after extraction?

Done.

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/create_package.py (right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/create_package.py:35:
'NativeClientVSAddIn.dll'),
I assume you mean have the source be the path to the file, and the dest be just
a directory without file, then use the file name from the source. I am changing
to this.
On 2012/07/26 23:32:17, binji wrote:
> Maybe change to (path, zip_dir) to remove duplication

[noelallen1, 2012-07-31 20:24:24]

LGTM

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
File
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Properties/nacl_general.xml
(right):

http://codereview.chromium.org/10831030/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Properties/nacl_general.xml:19:
Description="Specifies the path to the Native Client SDK root directory"
Correct...  NACL_SDK_ROOT is expected to be .../sdk/pepper_XX

On 2012/07/28 01:13:11, tysand wrote:
> VSNaClSDKRoot defaults to $(NACL_SDK_ROOT) which we decided should point to a
> particular pepper version.  We could however have the user set
$(NACL_SDK_ROOT)
> to the actual root and then have VCNaClSDKRoot default to
> $(NACL_SDK_ROOT)\pepper_20 or whatever version is supported by the add-in.
> However, I think NACL_SDK_ROOT is used outside of the Visual Studio add-in, so
> we would need to assess those changes too?
> On 2012/07/27 00:17:41, noelallen1 wrote:
> > Does this point to SDK root?  or a particular pepper directory?
>

[binji, 2012-07-31 20:39:39]

lgtm, what functionality did you need from etree in 2.7.3?

[tysand, 2012-07-31 20:53:10]

On 2012/07/31 20:39:39, binji wrote:
> lgtm, what functionality did you need from etree in 2.7.3?

The default-namespace support is needed when writing the PPAPI template xml
since Visual Studio will complain if the default namespace isn't what it is
expecting (and no default namespace is not what it is expecting).