Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10831025: mac: Remove now-unneeded includes of cocoa_protocols.h (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, asanka, mihaip-chromium-reviews_chromium.org, jennb, jam, jeremya+watch_chromium.org, yoshiki+watch_chromium.org, Randy Smith (Not in Mondays), dcheng, Dmitry Titov, joi+watch-content_chromium.org, Aaron Boodman, Satish, darin-cc_chromium.org, jianli, pam+watch_chromium.org
Visibility:
Public.

Description

mac: Remove now-unneeded includes of cocoa_protocols.h BUG=137676 TEST=compiles TBR=OWNERS Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148560

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -61 lines) Patch
M chrome/browser/app_controller_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/animatable_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/color_chooser_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_quit_panel_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.h View 1 chunk +1 line, -2 lines 1 comment Download
M chrome/browser/ui/cocoa/download/download_item_button.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_show_all_cell.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/web_auth_flow_window_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hover_close_button.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/menu_button_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/menu_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/styled_text_field_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_view_picker_table.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_view_picker_table_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_titlebar_view_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_javascript_dialog_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_login_dialog_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/dialogs/select_file_dialog_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
https://chromiumcodereview.appspot.com/10831025/diff/1/chrome/browser/ui/cocoa/dev_tools_controller.h File chrome/browser/ui/cocoa/dev_tools_controller.h (right): https://chromiumcodereview.appspot.com/10831025/diff/1/chrome/browser/ui/cocoa/dev_tools_controller.h#newcode8 chrome/browser/ui/cocoa/dev_tools_controller.h:8: #import <Cocoa/Cocoa.h> For NSSplitViewDelegate
8 years, 5 months ago (2012-07-26 05:27:59 UTC) #1
Robert Sesek
lgtm
8 years, 5 months ago (2012-07-26 10:17:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10831025/1
8 years, 5 months ago (2012-07-26 15:14:33 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 16:31:37 UTC) #4 
Change committed as 148560

Powered by Google App Engine
This is Rietveld 408576698