Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 10831015: Pass large object by const ref (Closed)

Created:
8 years, 5 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pass large object by const ref CID=104336 BUG= TEST= TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153638

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ppapi/thunk/enter.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
Tyler Breisacher (Chromium)
8 years, 5 months ago (2012-07-25 22:18:54 UTC) #1
Kyle Horimoto
LGTM
8 years, 5 months ago (2012-07-25 22:26:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831015/1
8 years, 5 months ago (2012-07-25 22:31:16 UTC) #3
commit-bot: I haz the power
Presubmit check for 10831015-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-25 22:31:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831015/1
8 years, 5 months ago (2012-07-25 22:39:01 UTC) #5
dmichael (off chromium)
lgtm
8 years, 5 months ago (2012-07-25 22:45:12 UTC) #6
commit-bot: I haz the power
Try job failure for 10831015-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-26 01:16:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831015/1
8 years, 5 months ago (2012-07-26 02:59:24 UTC) #8
commit-bot: I haz the power
Try job failure for 10831015-1 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-07-26 06:17:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831015/1
8 years, 5 months ago (2012-07-26 17:07:54 UTC) #10
commit-bot: I haz the power
Try job failure for 10831015-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-26 18:00:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831015/1
8 years, 5 months ago (2012-07-26 18:11:09 UTC) #12
commit-bot: I haz the power
Try job failure for 10831015-1 (retry) on linux_rel for step "update". It's a second try, ...
8 years, 5 months ago (2012-07-26 22:48:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831015/5004
8 years, 5 months ago (2012-07-26 23:47:58 UTC) #14
commit-bot: I haz the power
Try job failure for 10831015-5004 on linux_chromeos for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=29188 Step "update" is always ...
8 years, 5 months ago (2012-07-26 23:59:31 UTC) #15
Kyle Horimoto
Want to try CQ again?
8 years, 4 months ago (2012-08-08 18:08:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831015/5004
8 years, 4 months ago (2012-08-08 18:10:25 UTC) #17
commit-bot: I haz the power
Try job failure for 10831015-5004 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 19:32:25 UTC) #18
Kyle Horimoto
Retry? haha
8 years, 3 months ago (2012-08-28 03:45:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831015/5004
8 years, 3 months ago (2012-08-28 03:47:55 UTC) #20
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 07:00:39 UTC) #21
Change committed as 153638

Powered by Google App Engine
This is Rietveld 408576698