Issue 10831011: Wrench menu needs to respond to touch events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831011: Wrench menu needs to respond to touch events. (Closed)

Created:
8 years, 4 months ago by girard

Modified:
8 years, 4 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Wrench menu needs to respond to touch events. Touches generate emulated mouse events. The menu controller was unintentionally ignoring these events. BUG=138356 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148767

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ui/views/controls/menu/menu_controller.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

girard

Wrench menu was (unintentionally) ignoring touch events in windows. Not anymore!

8 years, 4 months ago (2012-07-25 19:53:24 UTC) #1

girard

Tests were checking for an exact left-click, which failed for an emulated left-click.

8 years, 4 months ago (2012-07-27 15:27:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/10831011/1

8 years, 4 months ago (2012-07-27 15:37:01 UTC) #4

Change committed as 148767