Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5713)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

Issue 10831008: Refactor and fix declarative webRequest API permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed license headers Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc
index ce978b25ddffbf40a1ab14682a36412f8c872292..ad0348b428e673ee39fb4832752348dbe83491a1 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc
@@ -8,6 +8,7 @@
#include "chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h"
#include "chrome/browser/extensions/api/web_request/web_request_api_helpers.h"
+#include "chrome/browser/extensions/api/web_request/web_request_permissions.h"
#include "chrome/browser/extensions/extension_system.h"
#include "net/url_request/url_request.h"
@@ -46,6 +47,7 @@ WebRequestRulesRegistry::GetMatches(net::URLRequest* request,
std::list<LinkedPtrEventResponseDelta> WebRequestRulesRegistry::CreateDeltas(
const ExtensionInfoMap* extension_info_map,
net::URLRequest* request,
+ bool crosses_incognito,
RequestStages request_stage,
const WebRequestRule::OptionalRequestData& optional_request_data) {
if (webrequest_rules_.empty())
@@ -92,9 +94,6 @@ std::list<LinkedPtrEventResponseDelta> WebRequestRulesRegistry::CreateDeltas(
const ExtensionId& extension_id = rule_id.first;
const WebRequestRule* rule = webrequest_rules_[rule_id].get();
CHECK(rule);
- const extensions::Extension* extension = NULL;
- if (extension_info_map)
- extension = extension_info_map->extensions().GetByID(extension_id);
// Skip rule if a previous rule of this extension instructed to ignore
// all rules with a lower priority than min_priorities[extension_id].
@@ -103,8 +102,8 @@ std::list<LinkedPtrEventResponseDelta> WebRequestRulesRegistry::CreateDeltas(
continue;
std::list<LinkedPtrEventResponseDelta> rule_result =
- rule->CreateDeltas(extension, request, request_stage,
- optional_request_data);
+ rule->CreateDeltas(extension_info_map, request, crosses_incognito,
+ request_stage, optional_request_data);
result.splice(result.begin(), rule_result);
min_priorities[extension_id] = std::max(current_min_priority,

Powered by Google App Engine
This is Rietveld 408576698