Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

Issue 10831008: Refactor and fix declarative webRequest API permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed license headers Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
index bb95594732b33c260c27450902e881fdac519739..11612587a00085dcec493e786be2efa00734146c 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
@@ -148,14 +148,16 @@ TEST(WebRequestActionTest, TestPermissions) {
// Check that redirect works on regular URLs but not on protected URLs.
TestURLRequest regular_request(GURL("http://test.com"), NULL, &context);
std::list<LinkedPtrEventResponseDelta> deltas =
- action_set->CreateDeltas(NULL, &regular_request, ON_BEFORE_REQUEST,
- WebRequestRule::OptionalRequestData(), "ext1", base::Time());
+ action_set->CreateDeltas(NULL, "ext1", &regular_request, false,
+ ON_BEFORE_REQUEST, WebRequestRule::OptionalRequestData(),
+ base::Time());
EXPECT_EQ(1u, deltas.size());
TestURLRequest protected_request(GURL(extension_urls::kGalleryBrowsePrefix),
NULL, &context);
- deltas = action_set->CreateDeltas(NULL, &protected_request, ON_BEFORE_REQUEST,
- WebRequestRule::OptionalRequestData(), "ext1", base::Time());
+ deltas = action_set->CreateDeltas(NULL, "ext1", &protected_request, false,
+ ON_BEFORE_REQUEST, WebRequestRule::OptionalRequestData(),
+ base::Time());
EXPECT_EQ(0u, deltas.size());
}

Powered by Google App Engine
This is Rietveld 408576698