Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

Issue 10831008: Refactor and fix declarative webRequest API permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed license headers Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_ registry.h" 5 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_ registry.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/memory/linked_ptr.h" 9 #include "base/memory/linked_ptr.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 331
332 std::vector<linked_ptr<RulesRegistry::Rule> > rules_to_add_2(1); 332 std::vector<linked_ptr<RulesRegistry::Rule> > rules_to_add_2(1);
333 rules_to_add_2[0] = CreateRedirectRule("http://www.bar.com"); 333 rules_to_add_2[0] = CreateRedirectRule("http://www.bar.com");
334 error = registry->AddRules(kExtensionId2, rules_to_add_2); 334 error = registry->AddRules(kExtensionId2, rules_to_add_2);
335 EXPECT_EQ("", error); 335 EXPECT_EQ("", error);
336 336
337 GURL url("http://www.google.com"); 337 GURL url("http://www.google.com");
338 TestURLRequestContext context; 338 TestURLRequestContext context;
339 TestURLRequest request(url, NULL, &context); 339 TestURLRequest request(url, NULL, &context);
340 std::list<LinkedPtrEventResponseDelta> deltas = 340 std::list<LinkedPtrEventResponseDelta> deltas =
341 registry->CreateDeltas(NULL, &request, ON_BEFORE_REQUEST, 341 registry->CreateDeltas(NULL, &request, false, ON_BEFORE_REQUEST,
342 WebRequestRule::OptionalRequestData()); 342 WebRequestRule::OptionalRequestData());
343 343
344 // The second extension is installed later and will win for this reason 344 // The second extension is installed later and will win for this reason
345 // in conflict resolution. 345 // in conflict resolution.
346 ASSERT_EQ(2u, deltas.size()); 346 ASSERT_EQ(2u, deltas.size());
347 deltas.sort(&helpers::InDecreasingExtensionInstallationTimeOrder); 347 deltas.sort(&helpers::InDecreasingExtensionInstallationTimeOrder);
348 348
349 std::list<LinkedPtrEventResponseDelta>::iterator i = deltas.begin(); 349 std::list<LinkedPtrEventResponseDelta>::iterator i = deltas.begin();
350 LinkedPtrEventResponseDelta winner = *i++; 350 LinkedPtrEventResponseDelta winner = *i++;
351 LinkedPtrEventResponseDelta loser = *i; 351 LinkedPtrEventResponseDelta loser = *i;
(...skipping 27 matching lines...) Expand all
379 379
380 std::vector<linked_ptr<RulesRegistry::Rule> > rules_to_add_3(1); 380 std::vector<linked_ptr<RulesRegistry::Rule> > rules_to_add_3(1);
381 rules_to_add_3[0] = CreateIgnoreRule(); 381 rules_to_add_3[0] = CreateIgnoreRule();
382 error = registry->AddRules(kExtensionId, rules_to_add_3); 382 error = registry->AddRules(kExtensionId, rules_to_add_3);
383 EXPECT_EQ("", error); 383 EXPECT_EQ("", error);
384 384
385 GURL url("http://www.google.com/index.html"); 385 GURL url("http://www.google.com/index.html");
386 TestURLRequestContext context; 386 TestURLRequestContext context;
387 TestURLRequest request(url, NULL, &context); 387 TestURLRequest request(url, NULL, &context);
388 std::list<LinkedPtrEventResponseDelta> deltas = 388 std::list<LinkedPtrEventResponseDelta> deltas =
389 registry->CreateDeltas(NULL, &request, ON_BEFORE_REQUEST, 389 registry->CreateDeltas(NULL, &request, false, ON_BEFORE_REQUEST,
390 WebRequestRule::OptionalRequestData()); 390 WebRequestRule::OptionalRequestData());
391 391
392 // The redirect by the first extension is ignored due to the ignore rule. 392 // The redirect by the first extension is ignored due to the ignore rule.
393 ASSERT_EQ(1u, deltas.size()); 393 ASSERT_EQ(1u, deltas.size());
394 LinkedPtrEventResponseDelta effective_rule = *(deltas.begin()); 394 LinkedPtrEventResponseDelta effective_rule = *(deltas.begin());
395 395
396 EXPECT_EQ(kExtensionId2, effective_rule->extension_id); 396 EXPECT_EQ(kExtensionId2, effective_rule->extension_id);
397 EXPECT_EQ(base::Time() + base::TimeDelta::FromDays(2), 397 EXPECT_EQ(base::Time() + base::TimeDelta::FromDays(2),
398 effective_rule->extension_install_time); 398 effective_rule->extension_install_time);
399 EXPECT_EQ(GURL("http://www.bar.com"), effective_rule->new_url); 399 EXPECT_EQ(GURL("http://www.bar.com"), effective_rule->new_url);
400 } 400 }
401 } // namespace extensions 401 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698