Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 10831006: Introduce unittest for passing NULL pointer for actual_range. (Closed)

Created:
8 years, 5 months ago by Seigo Nonaka
Modified:
8 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Introduce unittest for passing NULL pointer for actual_range. BUG=138723 TEST=ran content_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148339

Patch Set 1 : CL for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Seigo Nonaka
8 years, 5 months ago (2012-07-25 14:20:29 UTC) #1
Nico
lgtm Thanks!
8 years, 5 months ago (2012-07-25 14:26:20 UTC) #2
Nico
(You don't need the line "This unittest is for preventing same cause in crbug.com/138723." in ...
8 years, 5 months ago (2012-07-25 14:27:02 UTC) #3
Seigo Nonaka
On 2012/07/25 14:27:02, Nico wrote: > (You don't need the line "This unittest is for ...
8 years, 5 months ago (2012-07-25 14:35:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10831006/1002
8 years, 5 months ago (2012-07-25 14:35:52 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 16:18:10 UTC) #6
Change committed as 148339

Powered by Google App Engine
This is Rietveld 408576698