Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: runtime/vm/object.cc

Issue 10831005: Emit symbol maps for compiled code for use by the Linux perf tool. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: pre-review changes Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/main.cc ('K') | « runtime/vm/dart_api_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index b4f024f8aa55e91dd07fe83b246f0384f94e2d94..e38d97e15b092b2b5f210347518f9b4e92c580d7 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -4,6 +4,7 @@
#include "vm/object.h"
+#include "include/dart_api.h"
#include "platform/assert.h"
#include "vm/assembler.h"
#include "vm/bigint_operations.h"
@@ -6852,6 +6853,17 @@ RawCode* Code::FinalizeCode(const char* name, Assembler* assembler) {
MemoryRegion region(reinterpret_cast<void*>(instrs.EntryPoint()),
instrs.size());
assembler->FinalizeInstructions(region);
+ Dart_FileWriterFunction perf_events_writer = Dart::perf_events_writer();
+ if (perf_events_writer != NULL) {
+ const char* format = "%x %x %s\n";
+ uword addr = instrs.EntryPoint();
+ uword size = instrs.size();
+ intptr_t len = OS::SNPrint(NULL, 0, format, addr, size, name);
+ char* buffer = reinterpret_cast<char*>(
+ Isolate::Current()->current_zone()->Allocate(len + 1));
+ OS::SNPrint(buffer, len + 1, format, addr, size, name);
+ (*perf_events_writer)(buffer, len);
+ }
DebugInfo* pprof_symbol_generator = Dart::pprof_symbol_generator();
if (pprof_symbol_generator != NULL) {
ASSERT(strlen(name) != 0);
@@ -6911,7 +6923,9 @@ RawCode* Code::FinalizeCode(const char* name, Assembler* assembler) {
RawCode* Code::FinalizeCode(const Function& function, Assembler* assembler) {
// Calling ToFullyQualifiedCString is very expensive, try to avoid it.
- if (FLAG_generate_gdb_symbols || (Dart::pprof_symbol_generator() != NULL)) {
+ if (FLAG_generate_gdb_symbols ||
+ Dart::perf_events_writer() != NULL ||
+ Dart::pprof_symbol_generator() != NULL) {
return FinalizeCode(function.ToFullyQualifiedCString(), assembler);
} else {
return FinalizeCode("", assembler);
« runtime/bin/main.cc ('K') | « runtime/vm/dart_api_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698