Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 10830365: Initial crack at new workspace behavior. Each workspace now has its (Closed)

Created:
8 years, 4 months ago by sky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Initial crack at new workspace behavior. Each workspace now has its own window. This complicates usage of shell window ids a bit. I need to sort out animations (I've disabled them for the moment when this is enabled). BUG=137342 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1908 lines, -68 lines) Patch
M ash/ash.gyp View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash_switches.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ash/display/screen_position_controller.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 3 chunks +50 lines, -11 lines 0 comments Download
M ash/shell/window_watcher.h View 4 chunks +7 lines, -0 lines 0 comments Download
M ash/shell/window_watcher.cc View 1 chunk +30 lines, -2 lines 0 comments Download
M ash/shell_window_ids.h View 1 chunk +23 lines, -14 lines 0 comments Download
M ash/wm/activation_controller.cc View 7 chunks +46 lines, -5 lines 0 comments Download
M ash/wm/always_on_top_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/always_on_top_controller.cc View 2 chunks +19 lines, -7 lines 0 comments Download
M ash/wm/base_layout_manager.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/wm/window_cycle_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 8 chunks +64 lines, -15 lines 0 comments Download
M ash/wm/window_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
A ash/wm/workspace/workspace2.h View 1 chunk +74 lines, -0 lines 0 comments Download
A ash/wm/workspace/workspace2.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A ash/wm/workspace/workspace_manager2.h View 1 chunk +149 lines, -0 lines 0 comments Download
A ash/wm/workspace/workspace_manager2.cc View 1 chunk +522 lines, -0 lines 0 comments Download
A ash/wm/workspace/workspace_manager2_unittest.cc View 1 chunk +764 lines, -0 lines 0 comments Download
M ash/wm/workspace_controller.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/wm/workspace_controller.cc View 3 chunks +22 lines, -7 lines 0 comments Download
M ash/wm/workspace_controller_test_helper.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/workspace_controller_test_helper.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 4 months ago (2012-08-16 22:36:30 UTC) #1
Ben Goodger (Google)
8 years, 4 months ago (2012-08-16 22:41:06 UTC) #2
LGTM


On Thu, Aug 16, 2012 at 3:36 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Initial crack at new workspace behavior. Each workspace now has its
> own window. This complicates usage of shell window ids a bit.
>
> I need to sort out animations (I've disabled them for the moment when
> this is enabled).
>
> BUG=137342
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10830365/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ash/ash.gyp
>   M ash/ash_switches.h
>   M ash/ash_switches.cc
>   M ash/display/screen_position_**controller.cc
>   M ash/root_window_controller.cc
>   M ash/shell/window_watcher.h
>   M ash/shell/window_watcher.cc
>   M ash/shell_window_ids.h
>   M ash/wm/activation_controller.**cc
>   M ash/wm/always_on_top_**controller.h
>   M ash/wm/always_on_top_**controller.cc
>   M ash/wm/base_layout_manager.cc
>   M ash/wm/window_cycle_**controller.h
>   M ash/wm/window_cycle_**controller.cc
>   M ash/wm/window_util.h
>   A ash/wm/workspace/workspace2.h
>   A ash/wm/workspace/workspace2.cc
>   A ash/wm/workspace/workspace_**manager2.h
>   A ash/wm/workspace/workspace_**manager2.cc
>   A ash/wm/workspace/workspace_**manager2_unittest.cc
>   M ash/wm/workspace_controller.h
>   M ash/wm/workspace_controller.cc
>   M ash/wm/workspace_controller_**test_helper.h
>   M ash/wm/workspace_controller_**test_helper.cc
>   M chrome/app/generated_**resources.grd
>   M chrome/browser/about_flags.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698