Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 10830364: Extracted FlattenTransparency method. (Closed)

Created:
8 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 4 months ago
Reviewers:
Lei Zhang, gene
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Extracted FlattenTransparency method. No functionality was changed. Just exctracting some code. Method growing to large and I am going to extend RenderPage functionality. BUG=133527 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152054

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -45 lines) Patch
M chrome/renderer/print_web_view_helper_win.cc View 1 2 chunks +49 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 4 months ago (2012-08-16 22:26:30 UTC) #1
gene1
lgtm
8 years, 4 months ago (2012-08-16 22:31:08 UTC) #2
Lei Zhang
lgtm with nit below https://chromiumcodereview.appspot.com/10830364/diff/1/chrome/renderer/print_web_view_helper_win.cc File chrome/renderer/print_web_view_helper_win.cc (right): https://chromiumcodereview.appspot.com/10830364/diff/1/chrome/renderer/print_web_view_helper_win.cc#newcode96 chrome/renderer/print_web_view_helper_win.cc:96: Metafile* FlattenTransparency(Metafile* metafile, gfx::Size page_size) ...
8 years, 4 months ago (2012-08-17 02:30:00 UTC) #3
Vitaly Buka (NO REVIEWS)
https://chromiumcodereview.appspot.com/10830364/diff/1/chrome/renderer/print_web_view_helper_win.cc File chrome/renderer/print_web_view_helper_win.cc (right): https://chromiumcodereview.appspot.com/10830364/diff/1/chrome/renderer/print_web_view_helper_win.cc#newcode96 chrome/renderer/print_web_view_helper_win.cc:96: Metafile* FlattenTransparency(Metafile* metafile, gfx::Size page_size) { On 2012/08/17 02:30:00, ...
8 years, 4 months ago (2012-08-17 02:40:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10830364/6001
8 years, 4 months ago (2012-08-17 02:40:47 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 05:25:23 UTC) #6
Change committed as 152054

Powered by Google App Engine
This is Rietveld 408576698