chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm - Issue 10830353: Introduce InfoBarTabService API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

Issue 10830353: Introduce InfoBarTabService API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments, merge to LKGR Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

diff --git a/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm b/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

index e13e4daf63849372b9653e27f8b7f098f32ce710..5978e5ffa9551c74baf288d787f3056d67438e7b 100644

--- a/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

+++ b/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

@@ -29,7 +29,7 @@ using InfoBarUtilities::CreateLabel;

using InfoBarUtilities::AddMenuItem;

// TranslateInfoBarDelegate views specific method:

-InfoBar* TranslateInfoBarDelegate::CreateInfoBar(InfoBarTabHelper* owner) {

+InfoBar* TranslateInfoBarDelegate::CreateInfoBar(InfoBarTabService* owner) {

TranslateInfoBarControllerBase* infobar_controller = NULL;

switch (type_) {

case BEFORE_TRANSLATE:

@@ -100,7 +100,7 @@ InfoBar* TranslateInfoBarDelegate::CreateInfoBar(InfoBarTabHelper* owner) {

@implementation TranslateInfoBarControllerBase

- (id)initWithDelegate:(InfoBarDelegate*)delegate

- owner:(InfoBarTabHelper*)owner {

+ owner:(InfoBarTabService*)owner {

if ((self = [super initWithDelegate:delegate owner:owner])) {

originalLanguageMenuModel_.reset(

new LanguagesMenuModel([self delegate],