Issue 10830345: Attempt at fixing crash from ExtensionToolbarModel. See bug for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830345: Attempt at fixing crash from ExtensionToolbarModel. See bug for (Closed)

Created:
8 years, 4 months ago by sky

Modified:
8 years, 4 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Attempt at fixing crash from ExtensionToolbarModel. See bug for background as to what is happening. Long term the observer likely needs a type parameter, but this is to stop the crashing. BUG=142999 TEST=none R=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151835

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	chrome/browser/extensions/extension_toolbar_model.cc	View		2 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10830345/1

8 years, 4 months ago (2012-08-15 23:48:20 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-08-16 02:41:44 UTC) #4

Try job failure for 10830345-1 (retry) on win_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages