Issue 10830338: [net/dns] Don't conflate all unhandled errors into DNS_SERVER_FAILED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830338: [net/dns] Don't conflate all unhandled errors into DNS_SERVER_FAILED. (Closed)

Created:
8 years, 4 months ago by szym

Modified:
8 years, 4 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[net/dns] Don't conflate all unhandled errors into DNS_SERVER_FAILED. We are seeing significant fraction of DnsTransactions failing with DNS_SERVER_FAILED but can't tell if it's a socket error or an actual response from the server. BUG=142918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151748

Patch Set 1 #

Patch Set 2 : sync #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/dns/dns_transaction.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/10830338/1

8 years, 4 months ago (2012-08-15 18:26:26 UTC) #5

commit-bot: I haz the power

8 years, 4 months ago (2012-08-15 19:05:15 UTC) #6

Try job failure for 10830338-1 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages