Issue 10830332: [cros] Remove vertical clipping in OOBE step container.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830332: [cros] Remove vertical clipping in OOBE step container. (Closed)

Created:
8 years, 4 months ago by Ivan Korotkov

Modified:
8 years, 4 months ago

Reviewers:
ygorshenin1

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Remove vertical clipping in OOBE step container. Horizontal clipping is still needed for slide animations. Other minor fixes: *) Centered network step contents. *) Step logo is hidden initially to prevent flicker during boot/sign out into Login screen. BUG=142770 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151701

Patch Set 1 #

Patch Set 2 : overflow-x instead of original approach. #

Patch Set 3 : Revert #2 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
M	chrome/browser/resources/chromeos/login/display_manager.js	View	2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/login.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.css	View	2	3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Korotkov

Hmmm, specfying overflow-x didn't work actually :( Looks like one cannot set overflow-x to hidden ...

8 years, 4 months ago (2012-08-15 16:12:19 UTC) #3

http://crbug.com/142883

Expand Messages | Collapse Messages