Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10830322: aura: fix flashing when switching tabs rapidly (Closed)

Created:
8 years, 4 months ago by piman
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

aura: fix flashing when switching tabs rapidly The test was wrong (hence triggerring the DCHECK): host_->is_hidden() doesn't say anything about the last compositor frame that may still be pending, and sending the ACK causes the renderer to possibly render to the "front" surface in fast hide/show/hide/show transitions. --enable-ui-release-front-surface hides the effect, but it's visible without that flag. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
8 years, 4 months ago (2012-08-14 23:05:05 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-14 23:43:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10830322/1
8 years, 4 months ago (2012-08-15 01:13:18 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 04:10:31 UTC) #4
Change committed as 151645

Powered by Google App Engine
This is Rietveld 408576698