Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 10830317: Gtalk bug found in 809.1. Reverting to running current version of test only. (Closed)

Created:
8 years, 4 months ago by krenaud
Modified:
8 years, 3 months ago
Reviewers:
craigdh, krenaud1, Nirnimesh
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/extensions/gtalk/rc_version View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
krenaud1
Fixes gtalk test by running test on working version of extension. Test was broken due ...
8 years, 4 months ago (2012-08-14 19:09:12 UTC) #1
craigdh
lgtm, but you'll still need the ok from Nirnimesh before committing
8 years, 4 months ago (2012-08-14 19:13:02 UTC) #2
Nirnimesh
LGTM
8 years, 4 months ago (2012-08-14 19:14:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/krenaud@google.com/10830317/1
8 years, 4 months ago (2012-08-14 19:20:14 UTC) #4
Nirnimesh
8 years, 4 months ago (2012-08-14 21:16:58 UTC) #5
I've committed it by hand to bring some greenery to the pyauto bots.

Powered by Google App Engine
This is Rietveld 408576698