Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 10830316: Prefer Product_S/N when reading the serial number for enterprise enrollment. (Closed)

Created:
8 years, 4 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Prefer Product_S/N when reading the serial number for enterprise enrollment. This is effectively a partial revert of http://codereview.chromium.org/10542072/ for Lumpy devices, all other models remain unaffected because they don't have both the serial_number and Product_S/N keys in VPD. Background: The serial_number VPD key (which would be the right source in an ideal world) returns a checksum-suffixed serial number on Lumpy devices that includes a trailing checksum character. That unfortunately causes trouble with the server side, which uses the non-suffixed serial number. BUG=chromium:142681, chromium-os:31652 TEST=Check serial number reported on enterprise enrollment and used for auto-enrollment on Lumpy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/policy/browser_policy_connector.cc View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years, 4 months ago (2012-08-14 20:48:44 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698