src/runtime.cc - Issue 10830304: Ensure capacity when adding parts in String.replace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 10830304: Ensure capacity when adding parts in String.replace. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 146607def5edb2814ca921b4149269b49bf7f89f..d4d18c41679fc1d1b670b9298a01df2219b9c1ce 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -3128,6 +3128,7 @@ MUST_USE_RESULT static MaybeObject* StringReplaceRegExpWithString(

if (global_cache.HasException()) return Failure::Exception();

if (prev < subject_length) {

+ builder.EnsureCapacity(2);

builder.AddSubjectSlice(prev, subject_length);

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-2289.js » ('j') | no next file with comments »