Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: lib/dartdoc/mirrors/dart2js_mirror.dart

Issue 10830303: Refactor Library/CompilationUnit and how we define local Scope. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix reference in dart2js_mirror.dart Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dartdoc/mirrors/dart2js_mirror.dart
diff --git a/lib/dartdoc/mirrors/dart2js_mirror.dart b/lib/dartdoc/mirrors/dart2js_mirror.dart
index 1f3be5f544f874a9b1777c171a4af38bc2534f48..241cd2d86c02c4611ef59c056cc420e36c67ce22 100644
--- a/lib/dartdoc/mirrors/dart2js_mirror.dart
+++ b/lib/dartdoc/mirrors/dart2js_mirror.dart
@@ -236,7 +236,7 @@ class LibraryCompiler extends api.Compiler {
void processQueueList(Enqueuer world, List<LibraryElement> elements) {
backend.processNativeClasses(world, libraries.getValues());
for (var library in elements) {
- library.elements.forEach((_, element) {
+ library.localMembers.forEach((element) {
ahe 2012/08/14 12:45:26 I like this better than the old version.
world.addToWorkList(element);
});
}
@@ -486,7 +486,7 @@ class Dart2JsLibraryMirror extends Dart2JsObjectMirror
return _library.libraryTag.argument.dartString.slowToString();
} else {
// Use the file name as script name.
- String path = _library.script.uri.path;
+ String path = _library.uri.path;
ahe 2012/08/14 12:45:26 Also better, I think.
return path.substring(path.lastIndexOf('/') + 1);
}
}
@@ -684,12 +684,7 @@ class Dart2JsInterfaceMirror extends Dart2JsObjectMirror
void _ensureMembers() {
if (_members == null) {
_members = <Dart2JsMemberMirror>{};
- _class.constructors.forEach((_, e) {
- for (var member in _convertElementMemberToMemberMirrors(this, e)) {
- _members[member.canonicalName] = member;
- }
- });
- _class.localMembers.forEach((_, e) {
+ _class.localMembers.forEach((e) {
for (var member in _convertElementMemberToMemberMirrors(this, e)) {
_members[member.canonicalName] = member;
}

Powered by Google App Engine
This is Rietveld 408576698