Add GetFilelist/GetFile operations for Drive V2 API.

Add GetFilelist/GetFile operations for Drive V2 API.

GetFilelist corresponds to GetDocuments operation for WAPI.
GetFile corresponds to GetDocumentEntry operation for WAPI.

Code to use these operations will be sent for review later.

BUG=chromium:127728
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151648

[kochi, 2012-08-14 08:17:20]

Hi Ryo,

Could you review this?
Thanks,

[kochi, 2012-08-14 08:22:58]

Noticed that Ryo will be OOO tomorrow.

Satoru, could you review?

[satorux1, 2012-08-14 13:17:21]

LGTM with nits and a request:

http://codereview.chromium.org/10830300/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/drive_api_operations.cc (right):

http://codereview.chromium.org/10830300/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/drive_api_operations.cc:91: if
(!search_string_.empty())
add {}

http://codereview.chromium.org/10830300/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_documents_service.h (right):

http://codereview.chromium.org/10830300/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_documents_service.h:105: // Fetches a
filelist from |url| with |search_query|, using Drive V2 API. If
Do we need to say V2? The public documentation does not seem to say V2?

http://codereview.chromium.org/10830300/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_documents_service.h:110: virtual void
GetFilelist(const GURL& url,
GetFileList?

http://codereview.chromium.org/10830300/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_documents_service.h:112: const
GetDataCallback& callback) = 0;
Would it be difficult to create a new file like drive_api_service.h and put
Drive API stuff there?

gdata_documents_service.h was written for WAPI, adding Drive API code here would
be confusing. It's hard to tell if a function is for WAPI or Drive API.

That said, we should do

- rename gdata_documents_service.h -> gdata_wapi_service.h
- introduce drive_api_service.h

Could you do this in a separate patch? Please also file a bug.

http://codereview.chromium.org/10830300/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_documents_service.h:122: // Upon completion,
invokes |callback| with results on the calling thread.
reference URL? Is this also Drive API?

[kochi, 2012-08-15 04:17:17]

Thanks for the review!

https://chromiumcodereview.appspot.com/10830300/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/drive_api_operations.cc (right):

https://chromiumcodereview.appspot.com/10830300/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/drive_api_operations.cc:91: if
(!search_string_.empty())
On 2012/08/14 13:17:21, satorux1 wrote:
> add {}

Done.

https://chromiumcodereview.appspot.com/10830300/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_documents_service.h (right):

https://chromiumcodereview.appspot.com/10830300/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_documents_service.h:105: // Fetches a
filelist from |url| with |search_query|, using Drive V2 API. If
The Drive V1 API is so poor that only file access method
is provided, and no practical application can be written with it. So most
probably Drive API should refer to V2+.
If referring V2 sounds too noisy, I could remove it, but I prefer explicitly
saying we are using V2, not V1 or V3 for
clarity.

https://chromiumcodereview.appspot.com/10830300/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_documents_service.h:110: virtual void
GetFilelist(const GURL& url,
On 2012/08/14 13:17:21, satorux1 wrote:
> GetFileList?

This convention is following GetChangelist() above, and
operation name is also GetFilelistOperation.

https://chromiumcodereview.appspot.com/10830300/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_documents_service.h:112: const
GetDataCallback& callback) = 0;
On 2012/08/14 13:17:21, satorux1 wrote:
> Would it be difficult to create a new file like drive_api_service.h and put
> Drive API stuff there?
> 
> gdata_documents_service.h was written for WAPI, adding Drive API code here
would
> be confusing. It's hard to tell if a function is for WAPI or Drive API.
> 
> That said, we should do
> 
> - rename gdata_documents_service.h -> gdata_wapi_service.h
> - introduce drive_api_service.h
> 
> Could you do this in a separate patch? Please also file a bug.

Filed http://crbug.com/142809
I'll work on it.

https://chromiumcodereview.appspot.com/10830300/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_documents_service.h:122: // Upon completion,
invokes |callback| with results on the calling thread.
On 2012/08/14 13:17:21, satorux1 wrote:
> reference URL? Is this also Drive API?

Done.