Issue 10830298: GDataFileSystem::CloseFile needs not modify GDataEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830298: GDataFileSystem::CloseFile needs not modify GDataEntry. (Closed)

Created:
8 years, 4 months ago by kinaba

Modified:
8 years, 4 months ago

Reviewers:
satorux1

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GDataFileSystem::CloseFile needs not modify GDataEntry. The modification is not needed anymore, because for dirty files we always look up metadata from the local cache file (r148712). Besides, this patch renames OnXXXForCloseFile to CloseFileAfterXXX, to match the recent convention. BUG=142466 TEST=existing tests, in particular: browser_tests --gtest_filter='RemoteFileSystemExtensionApiTest.RemoteMountPoint' unit_tests --gtest_filter='GDataFileSystemTest.OpenAndCloseFile' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151437

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -135 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		1 chunk	+8 lines, -28 lines	0 comments	Download
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		3 chunks	+10 lines, -107 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

8 years, 4 months ago (2012-08-14 05:19:56 UTC) #2

LGTM!! We should do more of this. :)

http://codereview.chromium.org/10830298/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10830298/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:3403: }  // namespace gdata
97 lines are gone!!

Expand Messages | Collapse Messages