[mac] Don't consider kAutoupdateCheckFailed as a permanent failure.

[mac] Don't consider kAutoupdateCheckFailed as a permanent failure.

BUG=142416
TEST=Verify that a canary build will re-check the version after an update check failure (usually error 12).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151553

[csilv, 2012-08-14 01:05:02]

+mark for review

[Mark Mentovai, 2012-08-14 02:33:14]

http://codereview.chromium.org/10830295/diff/1/chrome/browser/ui/webui/help/v...
File chrome/browser/ui/webui/help/version_updater_mac.mm (right):

http://codereview.chromium.org/10830295/diff/1/chrome/browser/ui/webui/help/v...
chrome/browser/ui/webui/help/version_updater_mac.mm:80: recent_status ==
kAutoupdateInstallFailed ||
I think that you should remove install-failed for sure, and likely
promote-failed as well. install-failed can be a transient failure just like
check-failed. promote-failed doesn’t necessarily invalidate the possibility that
updates might be applied in the absence of promotion.

[csilv, 2012-08-14 17:32:51]

http://codereview.chromium.org/10830295/diff/1/chrome/browser/ui/webui/help/v...
File chrome/browser/ui/webui/help/version_updater_mac.mm (right):

http://codereview.chromium.org/10830295/diff/1/chrome/browser/ui/webui/help/v...
chrome/browser/ui/webui/help/version_updater_mac.mm:80: recent_status ==
kAutoupdateInstallFailed ||
On 2012/08/14 02:33:14, Mark Mentovai wrote:
> I think that you should remove install-failed for sure, and likely
> promote-failed as well. install-failed can be a transient failure just like
> check-failed. promote-failed doesn’t necessarily invalidate the possibility
that
> updates might be applied in the absence of promotion.

Done.

[Mark Mentovai, 2012-08-14 17:40:15]

LGTM

[commit-bot: I haz the power, 2012-08-14 17:57:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csilv@chromium.org/10830295/2002

[commit-bot: I haz the power, 2012-08-14 20:26:21]

Change committed as 151553