Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10830293: Fixes bug where Env/RootWindow would cache the wrong button (Closed)

Created:
8 years, 4 months ago by sky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Fixes bug where Env/RootWindow would cache the wrong button state. Specifically on a release they would cache MouseEvent::flags(), which includes the buttons that were released. I've plumbed through the ability to identify the button that was pressed/released. I'll implement windows in a separate patch. BUG=140102 TEST=none R=ben@chromium.org, sadrul@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151533

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M ui/aura/root_window.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/event.h View 1 2 3 chunks +18 lines, -5 lines 0 comments Download
M ui/base/event.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/base/events.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/win/events_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/base/x/events_x.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
8 years, 4 months ago (2012-08-14 00:27:29 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-14 01:35:34 UTC) #2
sadrul
LGTM
8 years, 4 months ago (2012-08-14 01:47:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10830293/2001
8 years, 4 months ago (2012-08-14 14:58:11 UTC) #4
commit-bot: I haz the power
Failed to apply patch for ui/base/event.h: While running patch -p1 --forward --force; patching file ui/base/event.h ...
8 years, 4 months ago (2012-08-14 14:58:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10830293/1009
8 years, 4 months ago (2012-08-14 17:04:05 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 19:17:36 UTC) #7
Change committed as 151533

Powered by Google App Engine
This is Rietveld 408576698