Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: ash/system/power/power_status_view.cc

Issue 10830292: Change the battery time display format according m23 spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash_strings.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/power/power_status_view.cc
diff --git a/ash/system/power/power_status_view.cc b/ash/system/power/power_status_view.cc
index d3843fb80f8f070e4973d9372e3e4716128294da..3b39426a966415c43b4d07d06369b77dd78ba73b 100644
--- a/ash/system/power/power_status_view.cc
+++ b/ash/system/power/power_status_view.cc
@@ -114,14 +114,18 @@ void PowerStatusView::UpdateTextForDefaultView() {
ui::ResourceBundle::GetSharedInstance().GetLocalizedString(
IDS_ASH_STATUS_TRAY_BATTERY_CALCULATING);
} else if (hour || min){
+ string16 minute = min < 10 ?
+ ASCIIToUTF16("0") + base::IntToString16(min) :
+ base::IntToString16(min);
battery_time =
l10n_util::GetStringFUTF16(
IDS_ASH_STATUS_TRAY_BATTERY_TIME_ONLY,
base::IntToString16(hour),
- base::IntToString16(min)) +
- ASCIIToUTF16(" - ");
+ minute);
}
- string16 battery_status = battery_time + battery_percentage;
+ string16 battery_status = battery_time.empty() ?
+ battery_percentage :
+ battery_percentage + ASCIIToUTF16(" - ") + battery_time;
time_status_label_->SetText(battery_status);
}
}
@@ -155,13 +159,21 @@ void PowerStatusView::UpdateTextForNotificationView() {
ui::ResourceBundle::GetSharedInstance().GetLocalizedString(
IDS_ASH_STATUS_TRAY_BATTERY_CALCULATING));
} else if (hour || min) {
- time_label_->SetText(
+ if (supply_status_.line_power_on) {
+ time_label_->SetText(
l10n_util::GetStringFUTF16(
- supply_status_.line_power_on ?
- IDS_ASH_STATUS_TRAY_BATTERY_TIME_UNTIL_FULL :
- IDS_ASH_STATUS_TRAY_BATTERY_TIME_UNTIL_EMPTY,
+ IDS_ASH_STATUS_TRAY_BATTERY_TIME_UNTIL_FULL,
base::IntToString16(hour),
base::IntToString16(min)));
+ } else {
+ // This is a low battery warning, which prompts user when battery
+ // time left is not much (ie in minutes).
+ min = hour * 60 + min;
+ time_label_->SetText(
+ l10n_util::GetStringFUTF16(
+ IDS_ASH_STATUS_TRAY_BATTERY_TIME_UNTIL_EMPTY,
+ base::IntToString16(min)));
+ }
} else {
time_label_->SetText(string16());
}
« no previous file with comments | « ash/ash_strings.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698