Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10830287: Adding AndroidProxySelectorTest to ContentShell (Closed)

Created:
8 years, 4 months ago by aurimas (slooooooooow)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

Adding AndroidProxySelectorTest to ContentShell Adding AndroidProxySelectorTests to the ContentShellTest bundle. These tests are used to check if the proxy settings are functioning correctly. CRBUG=136719 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151779

Patch Set 1 #

Patch Set 2 : Removed empty line #

Total comments: 4

Patch Set 3 : Adding net_javetests.xml TO BE REMOVED once Chris lands his change #

Patch Set 4 : Fixing Chris' nit #

Total comments: 6

Patch Set 5 : Fixing piman's nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -11 lines) Patch
M content/content_tests.gypi View 1 2 3 4 1 chunk +10 lines, -11 lines 0 comments Download
M content/shell/android/javatests/content_shell_test_apk.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download
A net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java View 1 chunk +322 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
aurimas (slooooooooow)
Hey Yaron and Chris, Do you mind looking over my CL that adds some new ...
8 years, 4 months ago (2012-08-13 19:57:19 UTC) #1
Yaron
Can you send a try job to android_test: git try --bot=android_test https://chromiumcodereview.appspot.com/10830287/diff/2001/net/net.gyp File net/net.gyp (right): ...
8 years, 4 months ago (2012-08-13 20:46:03 UTC) #2
cjhopman
https://chromiumcodereview.appspot.com/10830287/diff/2001/net/net.gyp File net/net.gyp (right): https://chromiumcodereview.appspot.com/10830287/diff/2001/net/net.gyp#newcode1995 net/net.gyp:1995: 'includes': [ '../build/java.gypi' ], Nit: Move the 'includes' to ...
8 years, 4 months ago (2012-08-13 21:09:53 UTC) #3
aurimas (slooooooooow)
I fixed the nit. Can you look and see if I did the right thing ...
8 years, 4 months ago (2012-08-13 22:40:27 UTC) #4
cjhopman
https://chromiumcodereview.appspot.com/10830287/diff/4002/net/net.gyp File net/net.gyp (right): https://chromiumcodereview.appspot.com/10830287/diff/4002/net/net.gyp#newcode2001 net/net.gyp:2001: '../base/base.gyp:base_java_test_support', On 2012/08/13 22:40:28, aurimas1 wrote: > Chris, is ...
8 years, 4 months ago (2012-08-13 22:42:47 UTC) #5
aurimas (slooooooooow)
Hey Will, Would you mind looking at my CL? Thanks, Aurimas
8 years, 4 months ago (2012-08-13 22:56:08 UTC) #6
Yaron
lgtm
8 years, 4 months ago (2012-08-13 23:14:04 UTC) #7
willchan no longer on Chromium
lgtm http://codereview.chromium.org/10830287/diff/4002/net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java File net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java (right): http://codereview.chromium.org/10830287/diff/4002/net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java#newcode10 net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java:10: * IMPORTANT: These test cases are generated from ...
8 years, 4 months ago (2012-08-14 23:24:34 UTC) #8
aurimas (slooooooooow)
http://codereview.chromium.org/10830287/diff/4002/net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java File net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java (right): http://codereview.chromium.org/10830287/diff/4002/net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java#newcode10 net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java:10: * IMPORTANT: These test cases are generated from net/android/tools/proxy_test_cases.py, ...
8 years, 4 months ago (2012-08-14 23:42:21 UTC) #9
aurimas (slooooooooow)
Hello Antoine, Could you take a look at my CL? I need an LGTM from ...
8 years, 4 months ago (2012-08-14 23:44:28 UTC) #10
piman
lgtm http://codereview.chromium.org/10830287/diff/4002/content/content_tests.gypi File content/content_tests.gypi (right): http://codereview.chromium.org/10830287/diff/4002/content/content_tests.gypi#newcode814 content/content_tests.gypi:814: 'action': ['cp', '<@(_inputs)', '<@(_outputs)'], FYI, you can use ...
8 years, 4 months ago (2012-08-15 01:19:18 UTC) #11
aurimas (slooooooooow)
Thanks for the copies hint. https://chromiumcodereview.appspot.com/10830287/diff/4002/content/content_tests.gypi File content/content_tests.gypi (right): https://chromiumcodereview.appspot.com/10830287/diff/4002/content/content_tests.gypi#newcode814 content/content_tests.gypi:814: 'action': ['cp', '<@(_inputs)', '<@(_outputs)'], ...
8 years, 4 months ago (2012-08-15 18:18:31 UTC) #12
piman
awesome. LGTM
8 years, 4 months ago (2012-08-15 19:18:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/10830287/10002
8 years, 4 months ago (2012-08-15 20:04:49 UTC) #14
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 23:10:19 UTC) #15 
Change committed as 151779

Powered by Google App Engine
This is Rietveld 408576698