Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 10830281: Fix test_suite.dart to fix dartc tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b206efe6cf9860e9bb0ce9cd40f175e7c317c76b..9063fe543055c0dff3bf68ffc33a58978aec5c54 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -472,6 +472,9 @@ class StandardTestSuite implements TestSuite {
return <Command>[new Command(shellPath(), arguments)];
case 'dartc':
+ for (var vmOption in vmOptions) {
+ args.add(vmOption);
+ }
return <Command>[new Command(shellPath(), args)];
default:
@@ -1037,8 +1040,8 @@ class StandardTestSuite implements TestSuite {
List<List<String>> getVmOptions(Map optionsFromFile) {
bool needsVmOptions =
- Contains(configuration['compiler'], const ['none', 'dart2dart']) &&
- Contains(configuration['runtime'], const ['vm', 'drt', 'dartium']);
+ Contains(configuration['compiler'], const ['none', 'dart2dart', 'dartc']) &&
+ Contains(configuration['runtime'], const ['none', 'vm', 'drt', 'dartium']);
if (!needsVmOptions) return [[]];
return optionsFromFile['vmOptions'];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698