Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 10830278: Fix: create ExtensionInfoMap earlier. (Closed)

Created:
8 years, 4 months ago by marja
Modified:
8 years, 4 months ago
Reviewers:
Finnur
CC:
chromium-reviews, rginda+watch_chromium.org, michaeln, rpetterson
Visibility:
Public.

Description

Fix: create ExtensionInfoMap earlier. This is needed so that ProfileImpl ctor can access DOMStorageContext. The ExtensionInfoMap is needed early, in ProfileIOData::InitializeOnUIThread. Construct it on demand. BUG=104292 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151291

Patch Set 1 #

Patch Set 2 : better fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/browser/extensions/extension_system.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
marja
Hi rlp, could you review this fix?
8 years, 4 months ago (2012-08-13 11:02:03 UTC) #1
marja
Oops, the fix was not right. Updated it. rlp: this no longer touches profiles, no ...
8 years, 4 months ago (2012-08-13 13:57:39 UTC) #2
Finnur
Yoyo is probably a better candidate to review this (cc-ed) but this looks innocent enough. ...
8 years, 4 months ago (2012-08-13 14:08:35 UTC) #3
marja
kthx. yoyo, I'm putting this to the commit queue, pls let me know if you ...
8 years, 4 months ago (2012-08-13 14:17:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10830278/5006
8 years, 4 months ago (2012-08-13 14:17:27 UTC) #5
Yoyo Zhou
On 2012/08/13 14:17:27, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
8 years, 4 months ago (2012-08-13 14:37:08 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 17:05:35 UTC) #7
Change committed as 151291

Powered by Google App Engine
This is Rietveld 408576698