Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10830276: Clang style checker: turn on checks for nested classes (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Clang style checker: turn on checks for nested classes BUG=139346, 136863 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/clang/scripts/plugin_flags.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
This is blocked by https://chromiumcodereview.appspot.com/10824229/ Also, when I compile with this locally, I get "Unknown ...
8 years, 4 months ago (2012-08-13 12:33:03 UTC) #1
hans
All clean-ups are now in, so this should be good to go in. The "Unknown ...
8 years, 4 months ago (2012-08-14 13:05:55 UTC) #2
Nico
LGTM I suppose you've run tryjobs with this before everything was done, so you know ...
8 years, 4 months ago (2012-08-14 15:04:17 UTC) #3
hans
8 years, 4 months ago (2012-08-14 15:31:39 UTC) #4
On 2012/08/14 15:04:17, Nico wrote:
> LGTM
> 
> I suppose you've run tryjobs with this before everything was done, so you know
> the flag actually works :-)

Yup, see e.g. the red linux_clang bot above :)

> After this lands, can you send a CL to turn this on by default in the plugin,
> and to remove the flag from the plugin? (And once that's rolled in, we can
> remove it from this file again.)

OK, will do.

Powered by Google App Engine
This is Rietveld 408576698