Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: vm/flow_graph_optimizer.h

Issue 10830275: Optimize expressions of the form (expr === true) when expr has boolean type. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: addressed comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « vm/compiler.cc ('k') | vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_FLOW_GRAPH_OPTIMIZER_H_ 5 #ifndef VM_FLOW_GRAPH_OPTIMIZER_H_
6 #define VM_FLOW_GRAPH_OPTIMIZER_H_ 6 #define VM_FLOW_GRAPH_OPTIMIZER_H_
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 namespace dart { 10 namespace dart {
11 11
12 template <typename T> class GrowableArray; 12 template <typename T> class GrowableArray;
13 13
14 class FlowGraphOptimizer : public FlowGraphVisitor { 14 class FlowGraphOptimizer : public FlowGraphVisitor {
15 public: 15 public:
16 explicit FlowGraphOptimizer(const GrowableArray<BlockEntryInstr*>& blocks) 16 explicit FlowGraphOptimizer(const GrowableArray<BlockEntryInstr*>& blocks)
17 : FlowGraphVisitor(blocks) {} 17 : FlowGraphVisitor(blocks) {}
18 virtual ~FlowGraphOptimizer() {} 18 virtual ~FlowGraphOptimizer() {}
19 19
20 void ApplyICData(); 20 void ApplyICData();
21 21
22 void OptimizeComputations();
23
22 virtual void VisitStaticCall(StaticCallComp* comp, BindInstr* instr); 24 virtual void VisitStaticCall(StaticCallComp* comp, BindInstr* instr);
23 virtual void VisitInstanceCall(InstanceCallComp* comp, BindInstr* instr); 25 virtual void VisitInstanceCall(InstanceCallComp* comp, BindInstr* instr);
24 virtual void VisitLoadIndexed(LoadIndexedComp* comp, BindInstr* instr); 26 virtual void VisitLoadIndexed(LoadIndexedComp* comp, BindInstr* instr);
25 virtual void VisitStoreIndexed(StoreIndexedComp* comp, BindInstr* instr); 27 virtual void VisitStoreIndexed(StoreIndexedComp* comp, BindInstr* instr);
26 virtual void VisitRelationalOp(RelationalOpComp* comp, BindInstr* instr); 28 virtual void VisitRelationalOp(RelationalOpComp* comp, BindInstr* instr);
27
28 virtual void VisitEqualityCompare(EqualityCompareComp* comp, 29 virtual void VisitEqualityCompare(EqualityCompareComp* comp,
29 BindInstr* instr); 30 BindInstr* instr);
30
31 virtual void VisitBind(BindInstr* instr); 31 virtual void VisitBind(BindInstr* instr);
32 32
33 private: 33 private:
34 bool TryReplaceWithBinaryOp(BindInstr* instr, 34 bool TryReplaceWithBinaryOp(BindInstr* instr,
35 InstanceCallComp* comp, 35 InstanceCallComp* comp,
36 Token::Kind op_kind); 36 Token::Kind op_kind);
37 bool TryReplaceWithUnaryOp(BindInstr* instr, 37 bool TryReplaceWithUnaryOp(BindInstr* instr,
38 InstanceCallComp* comp, 38 InstanceCallComp* comp,
39 Token::Kind op_kind); 39 Token::Kind op_kind);
40 40
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 95
96 private: 96 private:
97 const ParsedFunction& parsed_function_; 97 const ParsedFunction& parsed_function_;
98 bool still_changing_; 98 bool still_changing_;
99 DISALLOW_COPY_AND_ASSIGN(FlowGraphTypePropagator); 99 DISALLOW_COPY_AND_ASSIGN(FlowGraphTypePropagator);
100 }; 100 };
101 101
102 } // namespace dart 102 } // namespace dart
103 103
104 #endif // VM_FLOW_GRAPH_OPTIMIZER_H_ 104 #endif // VM_FLOW_GRAPH_OPTIMIZER_H_
OLDNEW
« no previous file with comments | « vm/compiler.cc ('k') | vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698