Issue 10830271: [net] Use only DnsConfigService to detect DNS changes in HostResolverImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830271: [net] Use only DnsConfigService to detect DNS changes in HostResolverImpl (Closed)

Created:
8 years, 4 months ago by szym

Modified:
8 years, 4 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[net] Use only DnsConfigService to detect DNS changes in HostResolverImpl The signals coming currently via DNSObserver are too noisy. DnsConfigService can weed out false positives, so switch to using it exclusively. BUG=142138 TEST=network requests work after network changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151278

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -34 lines)			Patch
	M	net/base/host_resolver_impl.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
	M	net/base/host_resolver_impl.cc	View		4 chunks	+19 lines, -30 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

szym

I'm not sure if this will resolve http://crbug.com/128509 but it's probably worthwhile anyway.

8 years, 4 months ago (2012-08-11 16:21:05 UTC) #1

mmenke1

On 2012/08/11 16:21:05, szym wrote: > I'm not sure if this will resolve http://crbug.com/128509 but ...

8 years, 4 months ago (2012-08-13 14:36:24 UTC) #2

mmenke

Sorry, wrong account. LGTM. Weird...My last comment, made 5 minutes ago from the same browser, ...

8 years, 4 months ago (2012-08-13 14:37:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/10830271/1

8 years, 4 months ago (2012-08-13 15:01:14 UTC) #4

Change committed as 151278

Expand Messages | Collapse Messages