media/base/media_switches.cc - Issue 10830268: Allow audio system to handle synchronized low-latency audio I/O

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/media_switches.cc

Issue 10830268: Allow audio system to handle synchronized low-latency audio I/O (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "media/base/media_switches.h"	5 #include "media/base/media_switches.h"

6	6

7 namespace switches {	7 namespace switches {

8	8

9 #if defined(OS_LINUX) \|\| defined(OS_FREEBSD) \|\| defined(OS_SOLARIS)	9 #if defined(OS_LINUX) \|\| defined(OS_FREEBSD) \|\| defined(OS_SOLARIS)

10 // The Alsa device to use when opening an audio stream.	10 // The Alsa device to use when opening an audio stream.

(...skipping 20 matching lines...) Expand all Loading...
31 // for details.	31 // for details.

32 const char kEnableExclusiveAudio[] = "enable-exclusive-audio";	32 const char kEnableExclusiveAudio[] = "enable-exclusive-audio";

33 #endif	33 #endif

34	34

35 // Set number of threads to use for video decoding.	35 // Set number of threads to use for video decoding.

36 const char kVideoThreads[] = "video-threads";	36 const char kVideoThreads[] = "video-threads";

37	37

38 // Enable browser-side audio mixer.	38 // Enable browser-side audio mixer.

39 const char kEnableAudioMixer[] = "enable-audio-mixer";	39 const char kEnableAudioMixer[] = "enable-audio-mixer";

40	40

	41 // Enable live audio input with getUserMedia() and the Web Audio API.

	42 const char kEnableWebAudioInput[] = "enable-webaudio-input";
	scherkus (not reviewing) 2012/09/10 11:46:32 general rule of thumb: switches should go in the * general rule of thumb: switches should go in the _switches.cc file where they are used since kEnableWebAudioInput affects higher-level components (gUM() / Web Audio) and is only used in src/content/ this switch should go under content_switches.cc Chris Rogers* 2012/09/10 19:21:38 It will need to be used in media (in the AudioMana Show quoted text On 2012/09/10 11:46:32, scherkus wrote: > general rule of thumb: switches should go in the _switches.cc file where they > are used > > since kEnableWebAudioInput affects higher-level components (gUM() / Web Audio) > and is only used in src/content/ this switch should go under content_switches.cc It will need to be used in media (in the AudioManagers). I originally had the switch in content_switches.h, but my code (not in this CL) in AudioManagerMac triggered a dependency violation. scherkus (not reviewing)* 2012/09/11 12:13:00 Good to know -- thanks! Show quoted text On 2012/09/10 19:21:38, Chris Rogers wrote: > On 2012/09/10 11:46:32, scherkus wrote: > > general rule of thumb: switches should go in the *_switches.cc file where they > > are used > > > > since kEnableWebAudioInput affects higher-level components (gUM() / Web Audio) > > and is only used in src/content/ this switch should go under > content_switches.cc > > It will need to be used in media (in the AudioManagers). I originally had the > switch in content_switches.h, but my code (not in this CL) in AudioManagerMac > triggered a dependency violation. Good to know -- thanks!
	43

41 } // namespace switches	44 } // namespace switches

OLD	NEW

« media/base/audio_renderer_sink.h ('K') | « media/base/media_switches.h ('k') | no next file » | no next file with comments »