Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 10830265: Test context_->GetCommandBufferProxy() before following it blindly. (Closed)

Created:
8 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Test context_->GetCommandBufferProxy() before following it blindly. Apparently it's possible to have the context WeakPtr not be cleared yet but have the underlying proxy already be gone. BUG=141880 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/renderer_gpu_video_decoder_factories.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ami GONE FROM CHROMIUM
I'm not really sure how this can arise, but I know this context/isContextLost/WeakPtr business is ...
8 years, 4 months ago (2012-08-10 19:55:27 UTC) #1
piman
lgtm
8 years, 4 months ago (2012-08-11 01:29:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10830265/1
8 years, 4 months ago (2012-08-11 01:32:29 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-12 02:24:50 UTC) #4
Change committed as 151193

Powered by Google App Engine
This is Rietveld 408576698