Issue 10830254: views: Pass only Browser pointer to FirstRunBubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830254: views: Pass only Browser pointer to FirstRunBubble. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Pass only Browser pointer to FirstRunBubble. We don't need to pass Profile because we can get it from Browser API, and we are trying to reduce the usage of Profile. R=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151220

Patch Set 1 : #

Total comments: 1

Patch Set 2 : fix nit #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -19 lines)			Patch
M	chrome/browser/ui/views/first_run_bubble.h	View		2 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/first_run_bubble.cc	View	1	4 chunks	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/views/first_run_bubble_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/10830254/diff/3005/chrome/browser/ui/views/first_run_bubble.cc File chrome/browser/ui/views/first_run_bubble.cc (right): http://codereview.chromium.org/10830254/diff/3005/chrome/browser/ui/views/first_run_bubble.cc#newcode52 chrome/browser/ui/views/first_run_bubble.cc:52: IDS_FR_BUBBLE_TITLE, search_engine_name)); Nit: If you inline, you can ...

8 years, 4 months ago (2012-08-11 22:52:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10830254/7

8 years, 4 months ago (2012-08-13 02:05:14 UTC) #4

Change committed as 151220

Expand Messages | Collapse Messages