Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3311)

Unified Diff: chrome/common/extensions/docs/server2/server_instance.py

Issue 10830252: Extensions Docs Server: Uniform handling of file not found errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/server_instance.py
diff --git a/chrome/common/extensions/docs/server2/server_instance.py b/chrome/common/extensions/docs/server2/server_instance.py
index 2fa2a953c5b4bbce80b7d23d5c2c48eecfec9001..7c1294fee19d3ea6d5a281815fe73cba2ac2a692 100644
--- a/chrome/common/extensions/docs/server2/server_instance.py
+++ b/chrome/common/extensions/docs/server2/server_instance.py
@@ -6,6 +6,8 @@ from fnmatch import fnmatch
import mimetypes
import os
+from file_system import FileNotFoundError
+
STATIC_DIR_PREFIX = 'docs/server2'
DOCS_PATH = 'docs'
@@ -30,8 +32,8 @@ class ServerInstance(object):
base, ext = os.path.splitext(path)
response.headers['content-type'] = mimetypes.types_map[ext]
return result
- except Exception:
- return ''
+ except FileNotFoundError:
+ return None
def Get(self, path, request, response):
templates = self._template_data_source_factory.Create(request)

Powered by Google App Engine
This is Rietveld 408576698