Issue 10830251: Remove preamble link if annotated step has no extra sections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830251: Remove preamble link if annotated step has no extra sections. (Closed)

Created:
8 years, 4 months ago by Mike Stip (use stip instead)

Modified:
8 years, 4 months ago

Reviewers:
cmp, lliabraa, bradnelson, bradn, Nicolas Sylvain

CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org

Base URL:
http://git.chromium.org/chromium/tools/build.git@master

Visibility:
Public.

Remove preamble link if annotated step has no extra sections. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150975

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -18 lines)			Patch
	M	scripts/master/chromium_step.py	View		2 chunks	+12 lines, -0 lines	0 comments	Download
	M	scripts/master/unittests/annotator_test.py	View		7 chunks	+59 lines, -18 lines	0 comments	Download

Total messages: 6 (0 generated)

cmp

lgtm You've got a good track record for posting CLs that add features along with ...

8 years, 4 months ago (2012-08-10 02:03:13 UTC) #2

Mike Stip (use stip instead)

On 2012/08/10 02:04:40, bradn wrote: > lgtm Clicking commit. Lane, let me know if you ...

8 years, 4 months ago (2012-08-10 02:14:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/10830251/1

8 years, 4 months ago (2012-08-10 02:15:00 UTC) #5

Change committed as 150975