Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1697)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 10830241: Inform GetEntropySource of whether or not metrics reporting will be enabled. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index 90e0ea5ec2cce2de4f8a59fe04821a906c1351da..53ab4b9de6fc4cad6d836a4ea0cb60a70f0460ac 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -87,10 +87,13 @@ class MetricsService
std::string GetClientId();
// Returns the preferred entropy source used to seed persistent activities
- // based on whether or not metrics reporting is permitted on this client. If
- // it is permitted, this returns the client ID concatenated with the low
- // entropy source. Otherwise, this just returns the low entropy source.
- std::string GetEntropySource();
+ // based on whether or not metrics reporting will permitted on this client.
+ // The caller must determine if metrics reorting will be enabled for this
Ilya Sherman 2012/08/09 16:47:29 nit: "reorting" -> "reporting"
SteveT 2012/08/09 17:18:30 Done.
+ // client and pass that state in as |reporting_will_be_enabled|. If
+ // |reporting_will_be_enabled| is true, this method returns the client ID
+ // concatenated with the low entropy source. Otherwise, this method just
+ // returns the low entropy source.
+ std::string GetEntropySource(bool reporting_will_be_enabled);
// Force the client ID to be generated. This is useful in case it's needed
// before recording.

Powered by Google App Engine
This is Rietveld 408576698