Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 10830235: Remove obsolete cruft in LazyBackgroundTaskQueue that dealt with queueing up (Closed)

Created:
8 years, 4 months ago by Matt Perry
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Remove obsolete cruft in LazyBackgroundTaskQueue that dealt with queueing up events for a closing background page. We now cancel the close instead, so we don't need to queue the events. BUG=136469 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -53 lines) Patch
M chrome/browser/extensions/lazy_background_task_queue.h View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.cc View 4 chunks +16 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
8 years, 4 months ago (2012-08-09 01:19:26 UTC) #1
Matt Perry
Note: I just reverted https://src.chromium.org/viewvc/chrome?view=rev&revision=133079 's changes to lazy_background_task_queue.*
8 years, 4 months ago (2012-08-09 01:20:08 UTC) #2
koz (OOO until 15th September)
Nice! lgtm
8 years, 4 months ago (2012-08-09 01:46:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10830235/1
8 years, 4 months ago (2012-08-09 02:04:06 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 03:59:58 UTC) #5
Change committed as 150716

Powered by Google App Engine
This is Rietveld 408576698