tests/isolate/isolate.status - Issue 10830230: Add Timer implementation for dart2js. Also moves tests to appropriate location.

Side by Side Diff: tests/isolate/isolate.status

Issue 10830230: Add Timer implementation for dart2js. Also moves tests to appropriate location. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 [ $runtime == vm ]	5 [ $runtime == vm ]

6 isolate2_negative_test: Skip # Need to resolve correct behaviour.	6 isolate2_negative_test: Skip # Need to resolve correct behaviour.

7 serialization_test: Skip # tests frog-specific serialization code	7 serialization_test: Skip # tests frog-specific serialization code

8 spawn_uri_test: Fail # test uses a ".js" suffix that is bogus on vm.	8 spawn_uri_test: Fail # test uses a ".js" suffix that is bogus on vm.

9 compute_this_script_browser_test: Skip # browser specific test	9 compute_this_script_browser_test: Skip # browser specific test

10	10

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 *: Skip	66 *: Skip

67	67

68 [ $arch == arm ]	68 [ $arch == arm ]

69 *: Skip	69 *: Skip

70	70

71 [ $compiler == dart2js && $browser ]	71 [ $compiler == dart2js && $browser ]

72 spawn_uri_test: Skip # dart2js does not support spawnUri yet	72 spawn_uri_test: Skip # dart2js does not support spawnUri yet

73 spawn_uri_negative_test: Skip # ditto	73 spawn_uri_negative_test: Skip # ditto

74 spawn_uri_vm_test: Skip # test uses a ".dart" suffix that only works in vm.	74 spawn_uri_vm_test: Skip # test uses a ".dart" suffix that only works in vm.

75 spawn_uri_vm_negative_test: Skip # ditto above.	75 spawn_uri_vm_negative_test: Skip # ditto above.

76 constructor_test: Fail, OK # dart2js does not support subclassing Isolate	76 constructor_test: Fail, OK # dart2js does not support subclassing Isolate
	kasperl 2012/08/09 06:15:33 Do we still have this test? Do we still have this test? Siggi Cherem (dart-lang) 2012/08/09 20:37:14 Done. Show quoted text On 2012/08/09 06:15:33, kasperl wrote: > Do we still have this test? Done.
77	77

78 [ $compiler == dart2js && $runtime == d8 ]	78 [ $compiler == dart2js && $runtime == d8 ]

79 constructor_test: Fail, OK # dart2js does not support subclassing Isolate	79 constructor_test: Fail, OK # dart2js does not support subclassing Isolate
	kasperl 2012/08/09 06:15:33 Do we still have this test? Do we still have this test? Siggi Cherem (dart-lang) 2012/08/09 20:37:14 Done. Show quoted text On 2012/08/09 06:15:33, kasperl wrote: > Do we still have this test? Done.
80 spawn_uri_test: Skip # loading another file is not supported in d8	80 spawn_uri_test: Skip # loading another file is not supported in d8
	kasperl 2012/08/09 06:15:33 Could some of these skips be fails instead? Maybe Could some of these skips be fails instead? Maybe even Fail, OK because we're not planning on making it work. Siggi Cherem (dart-lang) 2012/08/09 20:37:14 Done. Show quoted text On 2012/08/09 06:15:33, kasperl wrote: > Could some of these skips be fails instead? Maybe even Fail, OK because we're > not planning on making it work. Done.
81 spawn_uri_negative_test: Skip # ditto	81 spawn_uri_negative_test: Skip # ditto

82 spawn_uri_vm_test: Skip # test uses a ".dart" suffix that only works in vm.	82 spawn_uri_vm_test: Skip # test uses a ".dart" suffix that only works in vm.

83 spawn_uri_vm_negative_test: Skip # ditto above.	83 spawn_uri_vm_negative_test: Skip # ditto above.

	84 timer_cancel_test: Fail # Needs Timer to run.
	kasperl 2012/08/09 06:15:33 Fail, OK -- it is not something we're looking to a Fail, OK -- it is not something we're looking to address. Alternatively, we should try to make it possible to determine (at runtime) whether or not there is timer support on the platform (maybe new Timer can throw if not?) and rewrite the tests to check for that. When running on raw d8, I'd really like this to fail in a predictable (and tested) way. Siggi Cherem (dart-lang) 2012/08/09 20:37:15 actually, that's what happens today already. I add Show quoted text On 2012/08/09 06:15:33, kasperl wrote: > Fail, OK -- it is not something we're looking to address. Alternatively, we > should try to make it possible to determine (at runtime) whether or not there is > timer support on the platform (maybe new Timer can throw if not?) and rewrite > the tests to check for that. When running on raw d8, I'd really like this to > fail in a predictable (and tested) way. actually, that's what happens today already. I added a test for it (timer_not_available_test), marked all these as Fail, OK. I wonder if we should just mark them as Skip though - it doesn't seem that we are gaining any information from running these.
	85 timer_cancel1_test: Fail # Needs Timer to run.

	86 timer_cancel2_test: Fail # Needs Timer to run.

	87 multiple_timer_test: Fail # Needs Timer to run.

	88 timer_test: Fail # Needs Timer to run.

	89 timer_repeat_test: Fail # Needs Timer to run.

84	90

85 [ $compiler == dart2js && $runtime == none ]	91 [ $compiler == dart2js && $runtime == none ]

86 *: Fail, Pass # TODO(ahe): Triage these tests.	92 *: Fail, Pass # TODO(ahe): Triage these tests.

87	93

88 [ $compiler == dart2dart ]	94 [ $compiler == dart2dart ]

89 # Skip until we stabilize language tests.	95 # Skip until we stabilize language tests.

90 *: Skip	96 *: Skip

OLD	NEW

« lib/isolate/dart2js/timer_provider.dart ('K') | « lib/isolate/isolate_dart2js.dart ('k') | tests/isolate/multiple_timer_test.dart » ('j') | tests/isolate/multiple_timer_test.dart » ('J')