Don't use auth.json in me2me_virtual_host.

Don't use auth.json in me2me_virtual_host.

auth.json was previously used to store authentication tokens. Now host config
will be used to store them instead. This script will automatically upgrade
config files on systems that still have auth.json

BUG=120950
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150688

[Lambros, 2012-08-08 22:11:29]

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:269: def load_config(self):
Now that load_config no longer pulls data from a file, the semantics don't make
much sense.  It now looks as if this object has two internal copies of all its
state, and this method just copies one part to another part.  It would be better
if this method accepted a Config object as a parameter (instead of as a member
variable), and then the method "loads" data from the supplied Config object. 
Alternatively, have Config as a member variable (self.config), and don't copy
state - just have the fields "host_id", "host_name",... as getters (and setters)
that operate on self.config, or say that callers are allowed to operate on
self.config directly.

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:279: def save_config(self):
Same applies as for load_config.

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:285: def clear_config(self):
Similar thing here.  clear_config operates on self.config, but not on
self.host_id etc - so you have the paradox where self appears to have valid
config data, but self.config is cleared out.

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:780: auth.save_config()
Since save_config() no longer writes to disk, this is a change of behavior if
you get to "return 1" below "need_register_host:" - the auth data is no longer
saved in this case.  It's not a big deal, but it would be nice if we could save
the auth data if this happens, so the user doesn't have to re-enter their
details.

[Sergey Ulanov, 2012-08-08 22:41:03]

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:269: def load_config(self):
On 2012/08/08 22:11:29, Lambros wrote:
> Now that load_config no longer pulls data from a file, the semantics don't
make
> much sense.  It now looks as if this object has two internal copies of all its
> state, and this method just copies one part to another part.  It would be
better
> if this method accepted a Config object as a parameter (instead of as a member
> variable), and then the method "loads" data from the supplied Config object. 
> Alternatively, have Config as a member variable (self.config), and don't copy
> state - just have the fields "host_id", "host_name",... as getters (and
setters)
> that operate on self.config, or say that callers are allowed to operate on
> self.config directly.

You can look at it as if self.config is just a reference to the config object
and not internal state of this object (and it's shared between auth and host
objects). But yes, I agree it's better to just pass the config to this method.
Done.

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:279: def save_config(self):
On 2012/08/08 22:11:29, Lambros wrote:
> Same applies as for load_config.

Done.

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:285: def clear_config(self):
On 2012/08/08 22:11:29, Lambros wrote:
> Similar thing here.  clear_config operates on self.config, but not on
> self.host_id etc - so you have the paradox where self appears to have valid
> config data, but self.config is cleared out.

Moved this function to Config class.

http://codereview.chromium.org/10830225/diff/5001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:780: auth.save_config()
On 2012/08/08 22:11:29, Lambros wrote:
> Since save_config() no longer writes to disk, this is a change of behavior if
> you get to "return 1" below "need_register_host:" - the auth data is no longer
> saved in this case.  It's not a big deal, but it would be nice if we could
save
> the auth data if this happens, so the user doesn't have to re-enter their
> details.

Done.

[Lambros, 2012-08-09 01:20:27]

lgtm with nits

http://codereview.chromium.org/10830225/diff/11001/remoting/tools/me2me_virtu...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10830225/diff/11001/remoting/tools/me2me_virtu...
remoting/tools/me2me_virtual_host.py:778: logging.error("Faled to save host
configuration.")
s/Faled/Failed

http://codereview.chromium.org/10830225/diff/11001/remoting/tools/me2me_virtu...
remoting/tools/me2me_virtual_host.py:800: logging.error("Faled to save host
configuration.")
s/Faled/Failed

[Sergey Ulanov, 2012-08-09 02:13:09]

http://codereview.chromium.org/10830225/diff/11001/remoting/tools/me2me_virtu...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10830225/diff/11001/remoting/tools/me2me_virtu...
remoting/tools/me2me_virtual_host.py:778: logging.error("Faled to save host
configuration.")
On 2012/08/09 01:20:27, Lambros wrote:
> s/Faled/Failed

Done.

http://codereview.chromium.org/10830225/diff/11001/remoting/tools/me2me_virtu...
remoting/tools/me2me_virtual_host.py:800: logging.error("Faled to save host
configuration.")
On 2012/08/09 01:20:27, Lambros wrote:
> s/Faled/Failed

Done.