Ensure that cookies dialog is populated with new cookies on reload

chrome/browser/resources/options2/cookies_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
 
   /////////////////////////////////////////////////////////////////////////////
   // CookiesView class:
@@ skipping 14 matching lines @@
     __proto__: OptionsPage.prototype,
 
     /**
      * The timer id of the timer set on search query change events.
      * @type {number}
      * @private
      */
     queryDelayTimerId_: 0,
 
     /**
-     * The most recent search query, or null if the query is empty.
-     * @type {?string}
+     * The most recent search query, empty string if the query is empty.
+     * @type {string}
      * @private
      */
-    lastQuery_: null,
+    lastQuery_: '',

[battre, 2012/08/08 18:00:59]

I did this change, such that this.searchCookie(); triggered in
handleVisibleChange_ does not issue a new
chrome.send('updateCookieSearchResults', [filter]); here.

Without this change, CookiesViewHandler::SendChildren was called twice for the
root node on page reload. Once due to chrome.send('reloadCookies'); and once due
to chrome.send('updateCookieSearchResults', [filter]);

 
     initializePage: function() {
       OptionsPage.prototype.initializePage.call(this);
 
       this.pageDiv.querySelector('.cookies-search-box').addEventListener(
           'search', this.handleSearchQueryChange_.bind(this));
 
       this.pageDiv.querySelector('.remove-all-cookies-button').onclick =
           function(e) {
             chrome.send('removeAllCookies');
@@ skipping 49 matching lines @@
      * @private
      */
     handleVisibleChange_: function(e) {
       if (!this.visible)
         return;
 
       // Inform the CookiesViewHandler whether we are operating in regular
       // cookies dialog or the apps one.
       chrome.send('setViewContext', [this.isAppContext()]);
 
+      chrome.send('reloadCookies');
+
       if (!this.initialized_) {
         this.initialized_ = true;
         this.searchCookie();
       } else {
         this.pageDiv.querySelector('.cookies-list').redraw();
       }
 
       this.pageDiv.querySelector('.cookies-search-box').focus();
     },
 
@@ skipping 14 matching lines @@
   CookiesView.loadChildren = function(args) {
     $('cookies-list').loadChildren(args[0], args[1]);
   };
 
   // Export
   return {
     CookiesView: CookiesView
   };
 
 });