Issue 10830221: Ensure that cookies dialog is populated with new cookies on reload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830221: Ensure that cookies dialog is populated with new cookies on reload (Closed)

Created:
8 years, 4 months ago by battre

Modified:
8 years, 4 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews), Bernhard Bauer, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure that cookies dialog is populated with new cookies on reload BUG=125643 TEST=Ensure that the cookies dialog is still fully functional; also see bug report Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150783

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
M	chrome/browser/resources/options2/cookies_view.js	View		2 chunks	+5 lines, -3 lines	1 comment	Download
M	chrome/browser/ui/webui/options2/cookies_view_handler.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/cookies_view_handler.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

battre

Hi Evan, could you please review this CL? Thanks, Dominic https://chromiumcodereview.appspot.com/10830221/diff/5/chrome/browser/resources/options2/cookies_view.js File chrome/browser/resources/options2/cookies_view.js (right): https://chromiumcodereview.appspot.com/10830221/diff/5/chrome/browser/resources/options2/cookies_view.js#newcode39 ...

8 years, 4 months ago (2012-08-08 18:00:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/10830221/5

8 years, 4 months ago (2012-08-09 11:13:24 UTC) #3

Change committed as 150783

Expand Messages | Collapse Messages