Move localized_error from chrome/renderer into chrome/common.

Move localized_error from chrome/renderer into chrome/common.

Localized_error contains code to generate error strings, and it isn't render-thread specific. Chrome for iOS uses this class for error messages, but because we don't use the render thread at all, we've had to go into contortions of DEPS and gyp files to include it. This CL pulls localized_error out of renderer into common, which will bring great sanity to the iOS build.


BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150601

[mmenke, 2012-08-08 17:27:03]

LGTM, but you'll need a chrome OWNER to sign off on it.

https://chromiumcodereview.appspot.com/10830218/diff/1/chrome/common/localize...
File chrome/common/localized_error.h (right):

https://chromiumcodereview.appspot.com/10830218/diff/1/chrome/common/localize...
chrome/common/localized_error.h:27: class LocalizedError {
I suggest a comment somewhere that this is in common because of how it's used on
iOS.  Otherwise, it's possible someone could move it back.

[Miranda Callahan, 2012-08-08 17:38:26]

Thanks for the review. Nico, could you OWNERS-review, please?

http://chromiumcodereview.appspot.com/10830218/diff/1/chrome/common/localized...
File chrome/common/localized_error.h (right):

http://chromiumcodereview.appspot.com/10830218/diff/1/chrome/common/localized...
chrome/common/localized_error.h:27: class LocalizedError {
On 2012/08/08 17:27:03, Matt Menke wrote:
> I suggest a comment somewhere that this is in common because of how it's used
on
> iOS.  Otherwise, it's possible someone could move it back.

Added.

[Nico, 2012-08-08 17:56:07]

lgtm

http://chromiumcodereview.appspot.com/10830218/diff/2002/chrome/common/locali...
File chrome/common/localized_error.h (right):

http://chromiumcodereview.appspot.com/10830218/diff/2002/chrome/common/locali...
chrome/common/localized_error.h:29: // thread, this class needs to be in a
commonly accessible directory.
Remove comment

[mirandac, 2012-08-08 17:59:28]

Thanks, Nico!

http://chromiumcodereview.appspot.com/10830218/diff/2002/chrome/common/locali...
File chrome/common/localized_error.h (right):

http://chromiumcodereview.appspot.com/10830218/diff/2002/chrome/common/locali...
chrome/common/localized_error.h:29: // thread, this class needs to be in a
commonly accessible directory.
On 2012/08/08 17:56:07, Nico wrote:
> Remove comment

Done.

[commit-bot: I haz the power, 2012-08-08 18:02:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mirandac@chromium.org/10830218/9001

[commit-bot: I haz the power, 2012-08-08 19:27:50]

Change committed as 150601