Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 10830216: Enable storing and restoring sessionStorage by default. (Closed)

Created:
8 years, 4 months ago by marja
Modified:
8 years, 4 months ago
Reviewers:
michaeln, sail, awong
CC:
chromium-reviews, ajwong, jochen (gone - plz use gerrit), benm (inactive)
Visibility:
Public.

Description

Enable storing and restoring sessionStorage by default. BUG=104292 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152072

Patch Set 1 #

Patch Set 2 : fixed version #

Patch Set 3 : Fixed better. #

Patch Set 4 : more fixes #

Patch Set 5 : rebased #

Patch Set 6 : more fixes? #

Patch Set 7 : simpler fixes #

Patch Set 8 : fixes in; this is simple again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
marja
Hi michaeln, we could try enabling this feature by default now, wdyt? sail, can you ...
8 years, 4 months ago (2012-08-09 12:11:53 UTC) #1
awong
Drive-by -- if it factors into the decision at all, these two CLs: http://codereview.chromium.org/10831116/ http://codereview.chromium.org/10850010/ ...
8 years, 4 months ago (2012-08-09 17:35:00 UTC) #2
marja
Yes, indeed, the data will be lost for one restart after these CLs go in. ...
8 years, 4 months ago (2012-08-09 19:27:19 UTC) #3
michaeln
Nice timing, the m22 branch was just cut so flipping the switch now max's out ...
8 years, 4 months ago (2012-08-09 20:33:52 UTC) #4
rpetterson
LGTM
8 years, 4 months ago (2012-08-09 20:59:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10830216/1
8 years, 4 months ago (2012-08-09 21:01:12 UTC) #6
commit-bot: I haz the power
Try job failure for 10830216-1 (retry) on mac_rel for steps "nacl_integration, interactive_ui_tests, browser_tests". It's a ...
8 years, 4 months ago (2012-08-09 22:35:24 UTC) #7
marja
The ProfileImpl fixes got in, so this CL is simple again. The current patch set ...
8 years, 4 months ago (2012-08-17 07:04:26 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 07:04:34 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698