Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 10830210: Fix crbug.com/140910 (BrowsingDataRemover not working). (Closed)

Created:
8 years, 4 months ago by marja
Modified:
8 years, 4 months ago
Reviewers:
Mike West, battre
CC:
chromium-reviews, Evan Stade
Visibility:
Public.

Description

Fix crbug.com/140910 (BrowsingDataRemover not working). TBR=estade@chromium.org BUG=140910 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150531

Patch Set 1 #

Total comments: 1

Patch Set 2 : More places fixed, added DCHECK and conversion to BrowsingDataRemover. #

Messages

Total messages: 9 (0 generated)
Mike West
I love you, Marja. Good catch. LGTM. Land it, please. :)
8 years, 4 months ago (2012-08-08 07:55:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10830210/1
8 years, 4 months ago (2012-08-08 07:57:40 UTC) #2
commit-bot: I haz the power
Presubmit check for 10830210-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-08 07:57:42 UTC) #3
battre
https://chromiumcodereview.appspot.com/10830210/diff/1/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (left): https://chromiumcodereview.appspot.com/10830210/diff/1/chrome/browser/chrome_content_browser_client.cc#oldcode1563 chrome/browser/chrome_content_browser_client.cc:1563: BrowsingDataRemover* remover = new BrowsingDataRemover(profile, There are more calls ...
8 years, 4 months ago (2012-08-08 07:59:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10830210/1
8 years, 4 months ago (2012-08-08 08:01:10 UTC) #5
marja
A new patch set fixes the other usages, and adds a DCHECK and conversion (base::Time() ...
8 years, 4 months ago (2012-08-08 08:40:20 UTC) #6
Mike West
On 2012/08/08 08:40:20, marja wrote: > A new patch set fixes the other usages, and ...
8 years, 4 months ago (2012-08-08 08:41:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10830210/7002
8 years, 4 months ago (2012-08-08 08:42:19 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 10:07:39 UTC) #9
Change committed as 150531

Powered by Google App Engine
This is Rietveld 408576698