Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10830207: Add support for PNG representation in gfx::Image (Closed)

Created:
8 years, 4 months ago by cjhopman
Modified:
8 years, 4 months ago
Reviewers:
Lei Zhang, sky
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add support for PNG representation in gfx::Image Reviewed at: https://chromiumcodereview.appspot.com/10799014 Reverted for failure of mac_valgrind. Failure due (almost certainly) to a bug in Apple's code. Added suppression and filed bug (http://crbug.com/141293). BUG=123865 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150598

Patch Set 1 : Original CL #

Patch Set 2 : Add suppression #

Patch Set 3 : Missed small change from previous CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -32 lines) Patch
M chrome/browser/ui/tests/ui_gfx_image_unittest.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 1 chunk +19 lines, -0 lines 0 comments Download
M ui/gfx/image/image.h View 4 chunks +9 lines, -0 lines 0 comments Download
M ui/gfx/image/image.cc View 11 chunks +197 lines, -18 lines 0 comments Download
A ui/gfx/image/image_mac.mm View 1 chunk +47 lines, -0 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 2 chunks +64 lines, -3 lines 0 comments Download
M ui/gfx/image/image_unittest_util.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 3 chunks +40 lines, -1 line 0 comments Download
A ui/gfx/image/image_unittest_util_mac.mm View 1 chunk +21 lines, -0 lines 0 comments Download
M ui/gfx/image/image_util.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M ui/ui.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cjhopman
sky@: ui/ No changes here since previous CL. thestig@: tools/valgrind/
8 years, 4 months ago (2012-08-08 01:24:38 UTC) #1
Lei Zhang
valgrind lgtm
8 years, 4 months ago (2012-08-08 01:55:33 UTC) #2
sky
LGTM
8 years, 4 months ago (2012-08-08 04:57:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10830207/4001
8 years, 4 months ago (2012-08-08 15:06:20 UTC) #4
commit-bot: I haz the power
Try job failure for 10830207-4001 (retry) on mac_rel for steps "browser_tests, unit_tests". It's a second ...
8 years, 4 months ago (2012-08-08 16:49:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10830207/10002
8 years, 4 months ago (2012-08-08 17:09:59 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 19:12:51 UTC) #7 
Change committed as 150598

Powered by Google App Engine
This is Rietveld 408576698