Update license tool to check several additional directories

Update license tool to check several additional directories

Some of these directories are currently excluded from the license check. This change fixes the metadata where required and removes them from PRUNE_PATHS.

Other directories contain third-party code, but aren't in directories named 'third-party', so aren't checked by the license tool by default. This change fixes the metadata where required and adds them to ADDITIONAL_PATHS.

To avoid adding to about:credits licenses for modules that don't ship as part of the product, this change also introduces a special 'NOT_SHIPPED' value for the 'License File' field.

This will simplify the process of adding a tool to check license compatibility for the Android WebView build.

BUG=138921
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150800

[Steve Block, 2012-08-07 18:39:48]

http://codereview.chromium.org/10830201/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/README.chromium (right):

http://codereview.chromium.org/10830201/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/README.chromium:6: The LICENSE file was
generated from the licenses of all code in the examples.
I'd like to have the license tool check this directory so I don't have to
special-case it in the Android license tool -
http://codereview.chromium.org/10816041. This means I need to add a license
file, which will end up in about:credits.

The license tool currently prunes a bunch of third-party directories for code
like this that doesn't appear in the binary. However, there are plenty of cases
where we do provide license meta data for such code, so I assume it's OK to add
this LICENSE file?

[Nico, 2012-08-07 19:04:54]

looks fine to me (except for the extensions issue), but you might want to check
with the folks who added the "don't check these directory" rules you're removing
too.

http://codereview.chromium.org/10830201/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/README.chromium (right):

http://codereview.chromium.org/10830201/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/README.chromium:6: The LICENSE file was
generated from the licenses of all code in the examples.
On 2012/08/07 18:39:48, Steve Block wrote:
> I'd like to have the license tool check this directory so I don't have to
> special-case it in the Android license tool -
> http://codereview.chromium.org/10816041. This means I need to add a license
> file, which will end up in about:credits.
> 
> The license tool currently prunes a bunch of third-party directories for code
> like this that doesn't appear in the binary. However, there are plenty of
cases
> where we do provide license meta data for such code, so I assume it's OK to
add
> this LICENSE file?

It seems a bit silly if licenses for extensions example code show up in chrome's
about:credits. Is there no other way?

[Steve Block, 2012-08-09 12:08:40]

> It seems a bit silly if licenses for extensions example code show up in
chrome's
> about:credits. Is there no other way?
I've added a mechanism to avoid this.

[Nico, 2012-08-09 15:14:32]

lgtm

[Steve Block, 2012-08-09 15:21:57]

Thanks.

+ agl and mal for OWNERS

[agl, 2012-08-09 15:25:32]

lgtm

[Mark Mentovai, 2012-08-09 15:43:59]

LGTM for base OWNERS approval, without reading the rest of the change, but I
protest having to LGTM two-line README changes.